Skip to content

Commit 1103b3a

Browse files
committed
Update for 0.1.0 second submission
1 parent c6a8023 commit 1103b3a

4 files changed

Lines changed: 27 additions & 7 deletions

File tree

R/select.distance.R

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -967,10 +967,6 @@ select.distance <- function(data, names, group, alloc,
967967
dist_to_median <- split(bdout$distances, bdout$group)
968968
}
969969

970-
if (SampleCore.debug) {
971-
par(mfrow = n2mfrow(length(alloc)))
972-
}
973-
974970
out <-
975971
lapply(names(alloc), function(g) {
976972

R/select.diversity.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -944,7 +944,7 @@ select.diversity <- function(data, names, group, alloc,
944944
}, numeric(1))
945945

946946
if (SampleCore.debug) {
947-
print(range(candidate_scores))
947+
message(paste(range(candidate_scores)))
948948
}
949949

950950
best_subset <- candidate_subsets[[which.max(candidate_scores)]]

cran-comments-archive.md

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,13 @@
1+
# Version 0.1.0 - First submission
2+
3+
* First release.
4+
5+
### Test environments
6+
* local Windows 10 Pro 25H2, R-release (R 4.6.0) & R-devel (R 4.7.0 Pre-release).
7+
* local Ubuntu 20.04, R-release (R 4.6.0) & R-devel (R 4.7.0 Pre-release).
8+
* win-builder, R-release (R 4.6.0) & R-devel (R 4.7.0 Pre-release).
9+
* github macOS Sequoia 15.7.4, R-release (R 4.6.0).
10+
* github Ubuntu 24.04.4, R-release (R 4.6.0), R-oldrel-1 (R 4.5.3) & R-devel (R 4.7.0 Pre-release).
11+
12+
### R CMD check results
13+
* There were no NOTES, ERRORs or WARNINGs.

cran-comments.md

Lines changed: 13 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,17 @@
1-
# Version 0.1.0 - First submission
1+
# Version 0.1.0 - Second submission
22

3-
* First release.
3+
> `DESCRIPTION`: Adding references to description field of DESCRIPTION
4+
5+
As there are several diverse methods implemented, I would prefer to keep the references to the documentation and mention that in the description field of DESCRIPTION.
6+
7+
> `R/select.distance.R`: Please make sure that you do not change the user's options, par or working directory.
8+
9+
Removed the par settings/option change line as it was stale code as I had moved the latter plotting with `plot_dist` to `ggplot2` with facets.
10+
11+
> `R/select.diversity.R`: You write information messages to the console that cannot be easily
12+
suppressed.
13+
14+
Replaced print() with message().
415

516
### Test environments
617
* local Windows 10 Pro 25H2, R-release (R 4.6.0) & R-devel (R 4.7.0 Pre-release).

0 commit comments

Comments
 (0)