Equality for Locset and Region#2517
Open
thorstenhater wants to merge 6 commits into
Open
Conversation
thorstenhater
marked this pull request as ready for review
June 24, 2026 12:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So far, to decide whether two region were equal, we had to rely on
str(A) == str(B).This is slow, inconvenient, and somewhat misleading.
Thus, this PR introduces equality on those types under the following definition:
Two regions/locsets are equally iff they share the same construction.
Example:
This is somewhat stricter than one might expect, but for a complete
definition, one would need to convert these expressions to their concrete
representations using the morphology and labels, which is not desirable
due to performance reasons. And could also end in surprise when
two unrelated expressions are equal given a very specific morphology.