Skip to content

Attempt to fix exit value#47

Open
arcanericky wants to merge 1 commit into
devfrom
bug/exit-value
Open

Attempt to fix exit value#47
arcanericky wants to merge 1 commit into
devfrom
bug/exit-value

Conversation

@arcanericky
Copy link
Copy Markdown
Owner

First pass through the code to properly set exit value on errors to 1. This is to address #46. If I missed some locations we can get them patched up with additional PRs.

@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 8, 2023

Codecov Report

❌ Patch coverage is 66.66667% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 91.61%. Comparing base (837600d) to head (619f792).

Files with missing lines Patch % Lines
commands/root.go 66.66% 3 Missing and 1 partial ⚠️
commands/configreset.go 25.00% 2 Missing and 1 partial ⚠️
commands/configdelete.go 66.66% 2 Missing ⚠️
commands/configrename.go 75.00% 2 Missing ⚠️
commands/configupdate.go 71.42% 2 Missing ⚠️
commands/configlist.go 80.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev      #47      +/-   ##
==========================================
- Coverage   92.65%   91.61%   -1.04%     
==========================================
  Files          13       13              
  Lines         667      680      +13     
==========================================
+ Hits          618      623       +5     
- Misses         38       44       +6     
- Partials       11       13       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant