Update utils.py#41
Open
jiyzhang wants to merge 2 commits into
Open
Conversation
Contributor
|
Thanks for the fix @jiyzhang! once the tests clear I will merge |
Author
My update changed the interface of the function lm_stream_generator, which might be the reason to fail the test. I'll update a new version which will keep the output structure. |
Contributor
|
You need to run |
The token returned by mlx_lm.lm_steam_generato includes a field with mx.array which will fail the Pydantic dump with the error "TypeError: Object of type array is not JSON serializable"
Author
|
just add new commit which changes the mx.array to [] so the server won't fail with the error: This commit didn't change the response format and value. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in the function lm_stream_generator, the token returned by mlx_lm.lm_stream_generate is a mlx_lm.GenerationResponse, which includes a mx.array field
@dataclass class GenerationResponse: """ The output of :func:stream_generate`.`
As pydantic doesn't support mx.array, it will fail the model_dump() below
yield f"data: {json.dumps(chunk.model_dump())}\n\n"