Added tests for NotFoundError

Author: nareshbhatia

.jshintrc

@@ -244,4 +244,4 @@
     "globals": {
         // "sample": false
     }
-}
+}

src/index.js

@@ -40,6 +40,8 @@ function map(resultSet, maps, mapId, columnPrefix) {
  * @throws {NotFoundError} if object is not found and isRequired is true
  */
 function mapOne(resultSet, maps, mapId, columnPrefix, isRequired) {
+
+    // Set up a default value for isRequired
     if (isRequired === undefined) {
         isRequired = true;
     }
@@ -68,8 +70,8 @@ function mapOne(resultSet, maps, mapId, columnPrefix, isRequired) {
  */
 function injectResultInCollection(result, mappedCollection, maps, mapId, columnPrefix) {
 
-    // Make sure there is a columnPrefix
-    if (!columnPrefix) {
+    // Set up a default value for columnPrefix
+    if (columnPrefix === undefined) {
         columnPrefix = '';
     }
 
@@ -99,6 +101,11 @@ function injectResultInCollection(result, mappedCollection, maps, mapId, columnP
  */
 function injectResultInObject(result, mappedObject, maps, mapId, columnPrefix) {
 
+    // Set up a default value for columnPrefix
+    if (columnPrefix === undefined) {
+        columnPrefix = '';
+    }
+
     // Get the resultMap for this object
     let resultMap = _.find(maps, 'mapId', mapId);
 

test/.jshintrc

@@ -242,6 +242,7 @@
     // ----- Globals -----
     // false: variable as read-only
     "globals": {
+        "assert": false,
         "expect": false
     }
-}
+}

test/setup/setup.js

@@ -1,4 +1,5 @@
 module.exports = function() {
+    global.assert = global.chai.assert;
     global.expect = global.chai.expect;
 
     beforeEach(function() {

test/unit/mapper-test.js

@@ -84,6 +84,22 @@ describe('Mapper', () => {
         expect(mappedResult.getFullName()).to.equal('Elvis Presley');
     });
 
+    it('should throw a NotFoundError when mapOne() does not find an object', () => {
+
+        let fn = function() {
+            joinjs.mapOne([], domainMaps, 'userMap');
+        };
+
+        expect(fn).to.throw(joinjs.NotFoundError);
+    });
+
+    it('should not throw an Error when mapOne() does not find an object, but isRequired is set to false', () => {
+
+        var mappedResult = joinjs.mapOne([], domainMaps, 'userMap', '', false);
+
+        assert.isNull(mappedResult);
+    });
+
     it('should work when resultSet contains multiple top-level objects', () => {
         let resultSet = [
             {
@@ -97,7 +113,7 @@ describe('Mapper', () => {
                 security_name: 'Ace Ltd',
                 country_code: 'SZ',
                 country_name: 'Switzerland'
-            },
+            }
         ];
 
         let expectedResult = [