Speed up CI: cache Go tools, fix golangci-lint v2 config

Author: pierres

.github/actions/setup/action.yml

@@ -29,11 +29,6 @@ runs:
       with:
           go-version: ${{ inputs.go-version }}
           go-version-file: ${{ inputs.go-version && '' || 'go.mod' }}
-    - name: Install Go tools
-      run: |
-          go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest
-          go install github.com/daveshanley/vacuum@latest
-      shell: bash
     - name: Install dependencies
       run: just install
       shell: bash

.github/workflows/ci.yml

@@ -13,6 +13,18 @@ jobs:
               uses: actions/checkout@v6
             - name: Run Common Setup
               uses: ./.github/actions/setup
+            - name: Cache Go tools
+              uses: actions/cache@v5
+              with:
+                  path: |
+                      ~/go/bin/golangci-lint
+                      ~/go/bin/vacuum
+                  key: go-tools-${{ runner.os }}-${{ hashFiles('go.mod') }}
+                  restore-keys: go-tools-${{ runner.os }}-
+            - name: Install Go tools
+              run: |
+                  test -x ~/go/bin/golangci-lint || go install github.com/golangci/golangci-lint/v2/cmd/golangci-lint@latest
+                  test -x ~/go/bin/vacuum || go install github.com/daveshanley/vacuum@latest
             - name: Build Templates
               run: just build-templates
             - name: Run Linter

.golangci.yaml

@@ -19,6 +19,24 @@ linters:
     - staticcheck
     - unparam
     - usestdlibvars
+  settings:
+    gocyclo:
+      min-complexity: 20
+    dupl:
+      threshold: 100
+    goconst:
+      min-len: 3
+      min-occurrences: 3
+    mnd:
+      ignored-numbers:
+        - "0"
+        - "1"
+        - "2"
+        - "10"
+        - "100"
+      ignored-functions:
+        - "time.*"
+        - "http.StatusText"
   exclusions:
     rules:
       - path: _test\.go
@@ -41,22 +59,3 @@ formatters:
     gofumpt:
       extra-rules: true
       module-path: pkgstatsd
-
-linters-settings:
-  gocyclo:
-    min-complexity: 15
-  dupl:
-    threshold: 100
-  goconst:
-    min-len: 3
-    min-occurrences: 3
-  mnd:
-    ignored-numbers:
-      - "0"
-      - "1"
-      - "2"
-      - "10"
-      - "100"
-    ignored-functions:
-      - "time.*"
-      - "http.StatusText"