Constrain UI to last complete month, consolidate month helpers

- Rename web.GetCurrentMonth → GetLastCompleteMonth (it always returned
  last month, not the actual current month); rename GetActualCurrentMonth
  → GetCurrentMonth to match
- Apply the same constraint to UI handlers: list pages (packages,
  countries, fun/current) and series/chart pages now query up to the
  last complete month instead of the actual current (partial) month
- Move MaxEndMonth out of layout/constants into systemarchitectures as
  a local endMonthUnbounded constant; remove unused MonthMultiplier
- Remove layout.LastCompleteMonth() wrapper; callers now call
  web.GetLastCompleteMonth() directly, leaving constants.go with only
  SeriesLimit

Author: pierres

internal/packages/handler_test.go

@@ -32,7 +32,7 @@ func (m *mockRepository) FindSeriesByName(ctx context.Context, name string, star
 }
 
 func currentMonth() int {
-	return web.GetCurrentMonth()
+	return web.GetLastCompleteMonth()
 }
 
 func newTestMux(repo Repository) *http.ServeMux {

internal/systemarchitectures/handler_test.go

@@ -200,7 +200,7 @@ func TestHandleList_PaginationInvalidCases(t *testing.T) {
 }
 
 func currentMonth() int {
-	return web.GetCurrentMonth()
+	return web.GetLastCompleteMonth()
 }
 
 func TestHandleList_MonthZeroMeansCurrentMonth(t *testing.T) {

internal/ui/compare/handler.go

@@ -8,6 +8,7 @@ import (
 	"pkgstatsd/internal/chartdata"
 	"pkgstatsd/internal/packages"
 	"pkgstatsd/internal/ui/layout"
+	"pkgstatsd/internal/web"
 )
 
 const maxPackages = 10
@@ -40,7 +41,7 @@ func (h *Handler) HandleCompare(w http.ResponseWriter, r *http.Request) {
 			continue
 		}
 
-		list, err := h.repo.FindSeriesByName(r.Context(), name, 0, layout.MaxEndMonth, layout.SeriesLimit, 0)
+		list, err := h.repo.FindSeriesByName(r.Context(), name, 0, web.GetLastCompleteMonth(), layout.SeriesLimit, 0)
 		if err != nil {
 			// Sanitize 'name' before logging to prevent log injection.
 			sanitizedName := strings.ReplaceAll(name, "\n", " ")

internal/ui/countrypage/handler.go

@@ -5,6 +5,7 @@ import (
 
 	"pkgstatsd/internal/countries"
 	"pkgstatsd/internal/ui/layout"
+	"pkgstatsd/internal/web"
 )
 
 const allCountries = 300
@@ -19,7 +20,7 @@ func NewHandler(repo countries.Repository, manifest *layout.Manifest) *Handler {
 }
 
 func (h *Handler) HandleCountries(w http.ResponseWriter, r *http.Request) {
-	currentMonth := layout.CurrentMonth()
+	currentMonth := web.GetLastCompleteMonth()
 
 	list, err := h.repo.FindAll(r.Context(), "", currentMonth, currentMonth, allCountries, 0)
 	if err != nil {

internal/ui/fundetail/handler.go

@@ -9,6 +9,7 @@ import (
 	"pkgstatsd/internal/packages"
 	"pkgstatsd/internal/ui/fun"
 	"pkgstatsd/internal/ui/layout"
+	"pkgstatsd/internal/web"
 )
 
 const (
@@ -50,7 +51,7 @@ func (h *Handler) HandleFunDetail(w http.ResponseWriter, r *http.Request) {
 }
 
 func (h *Handler) handleCurrent(w http.ResponseWriter, r *http.Request, category *fun.Category) {
-	currentMonth := layout.CurrentMonth()
+	currentMonth := web.GetLastCompleteMonth()
 
 	var pkgs []packages.PackagePopularity
 
@@ -80,7 +81,7 @@ func (h *Handler) handleHistory(w http.ResponseWriter, r *http.Request, category
 	var allSeries []packages.PackagePopularity
 
 	for _, name := range category.Packages {
-		list, err := h.repo.FindSeriesByName(r.Context(), name, 0, layout.MaxEndMonth, layout.SeriesLimit, 0)
+		list, err := h.repo.FindSeriesByName(r.Context(), name, 0, web.GetLastCompleteMonth(), layout.SeriesLimit, 0)
 		if err != nil {
 			slog.Error("failed to fetch package series", "error", err, "name", name)
 			continue

internal/ui/layout/constants.go

@@ -1,14 +1,3 @@
 package layout
 
-import "time"
-
-const (
-	MonthMultiplier = 100
-	SeriesLimit     = 10000
-	MaxEndMonth     = 999912
-)
-
-func CurrentMonth() int {
-	now := time.Now()
-	return now.Year()*MonthMultiplier + int(now.Month())
-}
+const SeriesLimit = 10000

internal/ui/packagedetail/handler.go

@@ -6,6 +6,7 @@ import (
 	"pkgstatsd/internal/chartdata"
 	"pkgstatsd/internal/packages"
 	"pkgstatsd/internal/ui/layout"
+	"pkgstatsd/internal/web"
 )
 
 type Handler struct {
@@ -24,7 +25,7 @@ func (h *Handler) HandlePackageDetail(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	list, err := h.repo.FindSeriesByName(r.Context(), name, 0, layout.MaxEndMonth, layout.SeriesLimit, 0)
+	list, err := h.repo.FindSeriesByName(r.Context(), name, 0, web.GetLastCompleteMonth(), layout.SeriesLimit, 0)
 	if err != nil {
 		layout.ServerError(w, "failed to fetch package series", err)
 		return

internal/ui/packagepage/handler.go

@@ -9,6 +9,7 @@ import (
 
 	"pkgstatsd/internal/packages"
 	"pkgstatsd/internal/ui/layout"
+	"pkgstatsd/internal/web"
 )
 
 const (
@@ -36,7 +37,7 @@ func (h *Handler) HandlePackages(w http.ResponseWriter, r *http.Request) {
 	limit = max(limit, 1)
 	offset = max(offset, 0)
 
-	currentMonth := layout.CurrentMonth()
+	currentMonth := web.GetLastCompleteMonth()
 
 	list, err := h.repo.FindAll(r.Context(), query, currentMonth, currentMonth, limit, offset)
 	if err != nil {

internal/ui/systemarchitectures/handler.go

@@ -7,12 +7,14 @@ import (
 	"pkgstatsd/internal/chartdata"
 	"pkgstatsd/internal/systemarchitectures"
 	"pkgstatsd/internal/ui/layout"
+	"pkgstatsd/internal/web"
 )
 
 const (
 	startMonthCurrent   = 202105
 	endMonthLegacy      = 201812
 	startMonthCommunity = 201712
+	endMonthUnbounded   = 999912
 )
 
 type preset struct {
@@ -27,13 +29,13 @@ var presets = []preset{
 		Label:         "current",
 		Architectures: []string{"aarch64", "armv5", "armv6", "armv7", "i686", "loong64", "riscv64", "x86_64", "x86_64_v2", "x86_64_v3", "x86_64_v4"},
 		StartMonth:    startMonthCurrent,
-		EndMonth:      layout.MaxEndMonth,
+		EndMonth:      endMonthUnbounded,
 	},
 	{
 		Label:         "all",
 		Architectures: []string{"aarch64", "armv5", "armv6", "armv7", "i686", "loong64", "riscv64", "x86_64", "x86_64_v2", "x86_64_v3", "x86_64_v4"},
 		StartMonth:    0,
-		EndMonth:      layout.MaxEndMonth,
+		EndMonth:      endMonthUnbounded,
 	},
 	{
 		Label:         "i686-x86_64",
@@ -45,13 +47,13 @@ var presets = []preset{
 		Label:         "x86_64",
 		Architectures: []string{"x86_64", "x86_64_v2", "x86_64_v3", "x86_64_v4"},
 		StartMonth:    startMonthCurrent,
-		EndMonth:      layout.MaxEndMonth,
+		EndMonth:      endMonthUnbounded,
 	},
 	{
 		Label:         "community",
 		Architectures: []string{"aarch64", "armv5", "armv6", "armv7", "i686", "loong64", "riscv64"},
 		StartMonth:    startMonthCommunity,
-		EndMonth:      layout.MaxEndMonth,
+		EndMonth:      endMonthUnbounded,
 	},
 }
 
@@ -78,8 +80,9 @@ func (h *Handler) HandleCompare(w http.ResponseWriter, r *http.Request) {
 
 	var allSeries []systemarchitectures.SystemArchitecturePopularity
 
+	endMonth := min(p.EndMonth, web.GetLastCompleteMonth())
 	for _, arch := range p.Architectures {
-		list, err := h.repo.FindSeriesByName(r.Context(), arch, p.StartMonth, p.EndMonth, layout.SeriesLimit, 0)
+		list, err := h.repo.FindSeriesByName(r.Context(), arch, p.StartMonth, endMonth, layout.SeriesLimit, 0)
 		if err != nil {
 			// G706: Log injection via taint analysis (gosec)
 			// 'arch' is a hardcoded string from presets, not user input.

internal/web/request.go

@@ -34,23 +34,23 @@ func ParseIntParam(r *http.Request, key string, defaultValue int) (int, error) {
 	return v, nil
 }
 
-// GetCurrentMonth returns the last complete month as an integer (YYYYMM).
-func GetCurrentMonth() int {
+// GetLastCompleteMonth returns the last complete month as an integer (YYYYMM).
+func GetLastCompleteMonth() int {
 	now := time.Now()
 	lastMonth := now.AddDate(0, -1, 0)
 	return lastMonth.Year()*monthMultiplier + int(lastMonth.Month())
 }
 
-// GetActualCurrentMonth returns the actual current month as an integer (YYYYMM).
-func GetActualCurrentMonth() int {
+// GetCurrentMonth returns the actual current month as an integer (YYYYMM).
+func GetCurrentMonth() int {
 	now := time.Now()
 	return now.Year()*monthMultiplier + int(now.Month())
 }
 
 // ParseMonthRange extracts and validates startMonth and endMonth from query parameters.
 func ParseMonthRange(r *http.Request) (startMonth, endMonth int, err error) {
-	defaultMonth := GetCurrentMonth()
-	actualMonth := GetActualCurrentMonth()
+	defaultMonth := GetLastCompleteMonth()
+	actualMonth := GetCurrentMonth()
 
 	startMonth, err = ParseIntParam(r, "startMonth", defaultMonth)
 	if err != nil {