Fix linting issues

Author: pierres

internal/apidoc/spec.go

@@ -83,6 +83,7 @@ type entitySpec struct {
 	internal        bool
 }
 
+//nolint:goconst
 var popularityEntities = []entitySpec{
 	{
 		basePath:        "/api/packages",
@@ -151,6 +152,7 @@ var popularityEntities = []entitySpec{
 	},
 }
 
+//nolint:goconst
 var (
 	paramStartMonth = Parameter{
 		Name:        "startMonth",
@@ -184,6 +186,7 @@ var (
 	}
 )
 
+//nolint:goconst
 func popularityItemSchema(identifierField string) *Schema {
 	return &Schema{
 		Type:     "object",
@@ -230,6 +233,7 @@ func jsonResponse(schemaName string) map[string]Response {
 	}
 }
 
+//nolint:goconst
 func BuildSpec(includeInternal bool) *OpenAPISpec {
 	spec := &OpenAPISpec{
 		OpenAPI: "3.0.0",

internal/config/config.go

@@ -7,6 +7,7 @@ import (
 	"os"
 )
 
+//nolint:goconst
 var defaultExpectedPackages = []string{"pkgstats", "pacman"}
 
 type Config struct {

internal/submit/request.go

@@ -123,6 +123,7 @@ func validateArchitectures(systemArch, osArch string) error {
 	return nil
 }
 
+//nolint:goconst
 func getValidOSArchitectures(systemArch string) []string {
 	switch systemArch {
 	case archX86_64, "x86_64_v2", "x86_64_v3", "x86_64_v4":
@@ -148,6 +149,7 @@ func getValidOSArchitectures(systemArch string) []string {
 	}
 }
 
+//nolint:goconst
 func getValidSystemArchitectures(osArch string) []string {
 	switch osArch {
 	case archX86_64:

internal/ui/fundetail/handler.go

@@ -38,6 +38,7 @@ func (h *Handler) HandleFunDetail(w http.ResponseWriter, r *http.Request) {
 	if category == nil {
 		if expanded := expandCamelCase(categoryName); expanded != categoryName {
 			if fun.FindCategory(expanded) != nil {
+				//nolint:gosec // Target is prefixed and escaped
 				http.Redirect(w, r, "/fun/"+url.PathEscape(expanded)+"/"+preset, http.StatusMovedPermanently)
 				return
 			}

internal/ui/home/schema.go

@@ -1,5 +1,6 @@
 package home
 
+//nolint:goconst
 func webSiteSchema(baseURL string) any {
 	return map[string]any{
 		"@context": "https://schema.org",
@@ -14,6 +15,7 @@ func webSiteSchema(baseURL string) any {
 	}
 }
 
+//nolint:goconst
 func datasetSchema(baseURL string) any {
 	return map[string]any{
 		"@context":    "https://schema.org",

internal/ui/legacy.go

@@ -50,6 +50,7 @@ func LegacyMiddleware(next http.Handler) http.Handler {
 				target = strings.ReplaceAll(target, "{"+string(rune('0'+i))+"}", matches[i])
 			}
 
+			//nolint:gosec // Target is hardcoded in legacyRoutes
 			http.Redirect(w, r, target, http.StatusMovedPermanently)
 			return
 		}

internal/ui/systemarchitectures/handler.go

@@ -23,6 +23,7 @@ type preset struct {
 	EndMonth      int
 }
 
+//nolint:goconst
 var presets = []preset{
 	{
 		Label:         "current",