Test that encoded commas in compare URLs are decoded correctly

Author: pierres

internal/ui/compare/handler_test.go

@@ -62,6 +62,38 @@ func TestHandleCompare(t *testing.T) {
 	}
 }
 
+func TestHandleCompare_EncodedComma(t *testing.T) {
+	manifest, _ := layout.NewManifest([]byte(`{}`))
+	var lookedUp []string
+	repo := &mockRepo{
+		findSeriesByNameFunc: func(ctx context.Context, name string, _, _, _, _ int) (*packages.PackagePopularityList, error) {
+			lookedUp = append(lookedUp, name)
+			return &packages.PackagePopularityList{
+				Total: 1,
+				PackagePopularities: []packages.PackagePopularity{
+					{Name: name, StartMonth: 202501, EndMonth: 202501, Popularity: 10.5},
+				},
+			}, nil
+		},
+	}
+	handler := NewHandler(repo, manifest)
+
+	// %2C is a comma encoded by other apps when sharing the URL
+	req := httptest.NewRequest(http.MethodGet, "/compare/packages/pacman%2Cglibc", nil)
+	req.SetPathValue("names", "pacman,glibc")
+	rr := httptest.NewRecorder()
+
+	handler.HandleCompare(rr, req)
+
+	if rr.Code != http.StatusOK {
+		t.Errorf("expected status 200, got %d", rr.Code)
+	}
+
+	if len(lookedUp) != 2 || lookedUp[0] != "pacman" || lookedUp[1] != "glibc" {
+		t.Errorf("expected individual lookups for [pacman glibc], got %v", lookedUp)
+	}
+}
+
 func TestHandleCompare_SeriesError(t *testing.T) {
 	manifest, _ := layout.NewManifest([]byte(`{}`))
 	repo := &mockRepo{

internal/ui/packagelist/handler_test.go

@@ -121,6 +121,32 @@ func TestHandlePackages_WithCompare(t *testing.T) {
 	}
 }
 
+func TestHandlePackages_WithCompareEncoded(t *testing.T) {
+	manifest, _ := layout.NewManifest([]byte(`{}`))
+	var lookedUp []string
+	repo := &mockRepo{
+		findByNameFunc: func(_ context.Context, name string, _, _ int) (*packages.PackagePopularity, error) {
+			lookedUp = append(lookedUp, name)
+			return &packages.PackagePopularity{Name: name, Popularity: 5.0}, nil
+		},
+	}
+	handler := NewHandler(repo, manifest)
+
+	// %2C is a comma encoded by other apps when sharing the URL
+	req := httptest.NewRequest(http.MethodGet, "/packages?compare=glibc%2Clinux", nil)
+	rr := httptest.NewRecorder()
+
+	handler.HandlePackages(rr, req)
+
+	if rr.Code != http.StatusOK {
+		t.Errorf("expected status 200, got %d", rr.Code)
+	}
+
+	if len(lookedUp) != 2 || lookedUp[0] != "glibc" || lookedUp[1] != "linux" {
+		t.Errorf("expected individual lookups for [glibc linux], got %v", lookedUp)
+	}
+}
+
 func TestHandlePackages_WithCompareAndQuery(t *testing.T) {
 	manifest, _ := layout.NewManifest([]byte(`{}`))
 	findAllCalled := false