Skip to content

Fix: Table add & delete button layout shift #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pierres merged 2 commits into from
Mar 8, 2026
Merged

Fix: Table add & delete button layout shift #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f33168b
fix: right align plus and delete icons in tables to avoid horizontal …
m1rm Mar 8, 2026
7ee57c8
dev: mention need to manually rebuild assets
m1rm Mar 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,17 @@ the Arch Linux package statistics website.

# Setup
1. Run `just init` to install dependencies, build and generate fixtures
2. Run `just run` to start the application locally or `just dev` to watch for template and Go changes and rebuild automatically (requires [air](https://github.com/air-verse/air))
2. Run `just run` to start the application locally
3. Run `just` for a full list of available commands

# Contributions
# Contributing
## Dev Mode
Run `just dev` to watch for template and Go changes and rebuild automatically (requires [air](https://github.com/air-verse/air)).
The automatic rebuild does not include assets (images, JS, CSS) and all unused classes are stripped during the build process.
Thus, when changing classes for example, you might need to stop the dev server and run `just build-assets` and then start
the project again.

## Tests
For contributing you'll probably want to test your changes at least once
before submitting a pull request. Run `just test` to run all tests.

Expand Down
8 changes: 4 additions & 4 deletions internal/ui/packagepage/templates.templ
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ templ CompareTable(pkgs []packages.PackagePopularity, query string, offset int,
<tr>
<th scope="col">Package</th>
<th scope="col">Popularity</th>
<th scope="col" class="d-none d-lg-table-cell text-center">Compare</th>
<th scope="col" class="d-none d-lg-table-cell text-end">Compare</th>
</tr>
</thead>
<tbody>
Expand All @@ -95,7 +95,7 @@ templ CompareTable(pkgs []packages.PackagePopularity, query string, offset int,
<td class="w-75 align-middle">
@components.PopularityBar(pkg.Popularity)
</td>
<td class="align-middle text-center">
<td class="align-middle text-end">
<a
class="text-danger"
href={ toggleURL(query, offset, limit, compare, pkg.Name) }
Expand All @@ -117,7 +117,7 @@ templ PackageTable(pkgs []packages.PackagePopularity, query string, offset int,
<tr>
<th scope="col">Package</th>
<th scope="col">Popularity</th>
<th scope="col" class="d-none d-lg-table-cell text-center">Compare</th>
<th scope="col" class="d-none d-lg-table-cell text-end">Compare</th>
</tr>
</thead>
<tbody>
Expand All @@ -129,7 +129,7 @@ templ PackageTable(pkgs []packages.PackagePopularity, query string, offset int,
<td class="w-75 align-middle">
@components.PopularityBar(pkg.Popularity)
</td>
<td class="align-middle text-center">
<td class="align-middle text-end">
if isSelected(compare, pkg.Name) {
<a
class="text-danger"
Expand Down