appstream: drop dead client-timeout plumbing

The http.Client parameter on Update was always passed nil from main; the
fallback client timeouts (15m / 2m) were pure dead code since the ctx
deadline (10m in runCommand) always wins. Match the convention of the
other update commands: no client param, no hand-rolled timeouts. Also
unexport latestRelease — it's not called from outside the package.

Author: pierres

internal/appstream/update.go

@@ -11,31 +11,22 @@ import (
 	"log/slog"
 	"net/http"
 	"strings"
-	"time"
 )
 
 // archlinuxPackageJSON is the official package metadata used to resolve the
 // appstream-data snapshot directory name (pkgver). The XML base URL is passed
 // into Update as sourcesBase (from config.APPSTREAM_SOURCES_BASE / CLI).
 const archlinuxPackageJSON = "https://archlinux.org/packages/extra/any/archlinux-appstream-data/json/"
 
-const (
-	httpClientTimeoutRelease = 2 * time.Minute
-	httpClientTimeoutUpdate  = 15 * time.Minute
-)
-
 var componentRepos = []string{"core", "extra", "multilib"}
 
 type pkgJSON struct {
 	Pkgver string `json:"pkgver"`
 }
 
-// LatestRelease returns the snapshot directory name (e.g. "20260326") matching
+// latestRelease returns the snapshot directory name (e.g. "20260326") matching
 // the current extra/any archlinux-appstream-data package in the official repos.
-func LatestRelease(ctx context.Context, client *http.Client) (string, error) {
-	if client == nil {
-		client = &http.Client{Timeout: httpClientTimeoutRelease}
-	}
+func latestRelease(ctx context.Context, client *http.Client) (string, error) {
 	req, err := http.NewRequestWithContext(ctx, http.MethodGet, archlinuxPackageJSON, nil)
 	if err != nil {
 		return "", err
@@ -63,13 +54,11 @@ func LatestRelease(ctx context.Context, client *http.Client) (string, error) {
 // Update downloads AppStream component XML for core, extra, and multilib from
 // sourcesBase (see config.go), merges keywords and categories
 // by package name, writes both columns, and rebuilds the FTS index.
-func Update(ctx context.Context, db *sql.DB, client *http.Client, sourcesBase string) error {
-	if client == nil {
-		client = &http.Client{Timeout: httpClientTimeoutUpdate}
-	}
+func Update(ctx context.Context, db *sql.DB, sourcesBase string) error {
+	client := &http.Client{}
 	sourcesBase = strings.TrimSuffix(sourcesBase, "/") + "/"
 
-	version, err := LatestRelease(ctx, client)
+	version, err := latestRelease(ctx, client)
 	if err != nil {
 		return err
 	}

main.go

@@ -87,7 +87,7 @@ func runCommand(cmd string, cfg config.Config) int {
 			return 1
 		}
 	case "update-appstream":
-		if err := appstream.Update(ctx, db, nil, cfg.AppStreamSourcesBase); err != nil {
+		if err := appstream.Update(ctx, db, cfg.AppStreamSourcesBase); err != nil {
 			slog.Error("update-appstream failed", "error", err)
 			return 1
 		}