fix: failure to identify built packages on non-English locales#265
Merged
pbrisbin merged 4 commits intoFeb 24, 2026
Merged
Conversation
pbrisbin
reviewed
Feb 17, 2026
Corrections in response to suggestions
pbrisbin
enabled auto-merge (rebase)
February 20, 2026 15:38
pbrisbin
approved these changes
Feb 20, 2026
Match "*makepkg -fs*" before "git*" so the mock correctly returns MAKEPKG_FAIL for the combined "git checkout ... && makepkg -fs" command.
auto-merge was automatically disabled
February 24, 2026 12:22
Head branch was pushed to by a user without write access
Contributor
Author
pbrisbin
enabled auto-merge (rebase)
February 24, 2026 13:18
Member
|
Done. Thanks! |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
dist/completion/*dist/conf/downgrade.confdoc/*.ronnlocale/*.poREADME.mdDescription
Currently, the script parses
makepkgoutput log string"Finished making:"to identify built packages.This approach fails when the output is localized (non-English locale).
This PR replaces build log parsing with
makepkg --packagelistto identify built packages.