Add --share-log flag to upload install.log to paste.rs#4511
Open
Softer wants to merge 2 commits intoarchlinux:masterfrom
Open
Add --share-log flag to upload install.log to paste.rs#4511Softer wants to merge 2 commits intoarchlinux:masterfrom
Softer wants to merge 2 commits intoarchlinux:masterfrom
Conversation
1 task
Member
|
Just note that I started a conversation about an arch official channel for posting these logs. I created a ticket to track the progress on gitlab@archlinux #833 |
Contributor
Author
|
We can change --share-log behavior transparently for users any time we need without changing user's expectation. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the broken
curl ... https://0x0.sthint with an integratedarchinstall --share-logcommand that uploads/var/log/archinstall/install.logto paste.rs and prints a shareable URL. Also updates the same hint in the README, the bug report docs, and the GitHub bug issue template, so all four user-facing references now point to the working command.Refs #4396 (0x0.st has disabled uploads). Supersedes #4507, which removes the hint without offering a replacement.
Why paste.rs
install.logrenders as a readable page rather than a raw downloadinstall.logsizes)The endpoint is referenced exactly once - a constant in
archinstall/lib/share_log.py. If a self-hosted paste service is set up later, or 0x0.st returns, swapping it is a one-line change.Behavior
stderrstdout, so it can be piped (archinstall --share-log | xclip -sel clip)_log_sys_info()and uses bareprint()instead ofinfo()/warn(), so the file uploaded matches the file on disk byte-for-byte (no "About to upload..." line gets injected into the log)Test plan
archinstall --share-logon a live ISO - URL is printed and the paste matchesinstall.logbyte-for-bytearchinstall --share-logansweringn- exits cleanly without uploadingarchinstall --share-logwithinstall.logmissing - reports the error and exits non-zeroarchinstall --share-logwith no network - reports the error and exits non-zero