treewide: fix B904

Author: jelly

devel/management/commands/reporead.py

@@ -601,7 +601,7 @@ def locate_arch(arch):
     try:
         return Arch.objects.get(name=arch)
     except Arch.DoesNotExist:
-        raise CommandError('Specified architecture %s is not currently known.' % arch)
+        raise CommandError("Specified architecture %s is not currently known." % arch) from None
 
 
 def read_repo(primary_arch, repo_file, options):

devel/management/commands/retire_user.py

@@ -44,12 +44,12 @@ def handle(self, *args, **options):
         try:
             user = User.objects.get(username=options['user'])
         except User.DoesNotExist:
-            raise CommandError(u"Failed to find User '{}'".format(options['user']))
+            raise CommandError("Failed to find User '{}'".format(options["user"])) from None
 
         try:
             profile = UserProfile.objects.get(user=user)
         except UserProfile.DoesNotExist:
-            raise CommandError(u"Failed to find UserProfile")
+            raise CommandError("Failed to find UserProfile") from None
 
         # Set user inactive
         user.is_active = False

mirrors/fields.py

@@ -12,7 +12,7 @@ def to_python(self, value):
         try:
             value = IP(value)
         except ValueError as e:
-            raise ValidationError(str(e))
+            raise ValidationError(str(e)) from e
         return value
 
 

mirrors/models.py

@@ -103,7 +103,7 @@ def clean(self):
             protocol = urlparse(self.url).scheme
             self.protocol = MirrorProtocol.objects.get(protocol=protocol)
         except Exception as e:
-            raise ValidationError(e)
+            raise ValidationError(e) from e
         try:
             families = self.address_families()
             self.has_ipv4 = socket.AF_INET in families

packages/templatetags/package_extras.py

@@ -27,8 +27,8 @@ def render(self, context):
 def do_buildsortqs(parser, token):
     try:
         _, sortfield = token.split_contents()
-    except ValueError:
-        raise template.TemplateSyntaxError("%r tag requires a single argument" % token)
+    except ValueError as exc:
+        raise template.TemplateSyntaxError("%r tag requires a single argument" % token) from exc
     if not (sortfield[0] == sortfield[-1] and sortfield[0] in ('"', "'")):
         raise template.TemplateSyntaxError("%r tag's argument should be in quotes" % token)
     return BuildQueryStringNode(sortfield[1:-1])

packages/views/display.py

@@ -148,7 +148,7 @@ def details(request, name='', repo='', arch=''):
                 if ret:
                     return ret
             # we've tried everything at this point, nothing to see
-            raise Http404
+            raise Http404 from None
     else:
         return redirect_to_search(request, name, repo, arch)
 

packages/views/signoff.py

@@ -46,7 +46,7 @@ def signoff_package(request, name, repo, arch, revoke=False):
         try:
             signoff = Signoff.objects.get_from_package(package, request.user, False)
         except Signoff.DoesNotExist:
-            raise Http404
+            raise Http404 from None
         signoff.revoked = now()
         signoff.save(update_fields=('revoked',))
         created = False

pyproject.toml

@@ -75,7 +75,6 @@ select = [
 
 ignore = [
     "E731", # Do not assign a `lambda` expression, use a `def`
-    "B904", # Within an `except` clause, raise exceptions with `raise ... from err`
     "RUF012", # Mutable class attributes should be annotated with `typing.ClassVar`
     # TODO: add these one by one
     "DJ001", # Avoid using `null=True` on string-based fields such as `CharField`