Skip to content

is PreventAccessFromUnwantedDomains useful when InitializeTenancyByRequestData is used? #1418

@nikola-maric-aula

Description

@nikola-maric-aula

Hi i'm starting to use your project v4 and I stumbled upon a couple of inconsistencies, or maybe I'm just misunderstanding something.. Let me know if you'd welcome a PR to address my uncertainties.

Why would we want to high-prio init PreventAccessFromUnwantedDomains if we're only using InitializeTenancyByRequestData?

$tenancyMiddleware = array_merge([Middleware\PreventAccessFromUnwantedDomains::class], config('tenancy.identification.middleware'));

It also seems UsableWithEarlyIdentification->shouldBeSkipped() is checking for Tenancy::routeIsUniversal($route), so here the second condition is not necessary?

if ($this->shouldBeSkipped($route) || tenancy()->routeIsUniversal($route)) {

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions