You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hi @duganchen 👋, thanks for your contribution 👍
Even though I appreciate every help I don't want to merge this one. The reason is that these are my personal .files and I try to avoid anything related to scripting languages like Python.
I also like to keep my prompt as simple as possible without introducing any "clutter" or fill it up with tons of features that have only little benefit or are never used. I know many users got used to shell/prompt bootstrap projects like "Oh My ZSH" or spaceship that come with many features likes this, but keeping it simple is a great way to keep focus on the important parts.
Anyway, this is open source and you can simply use it for your own setup. One way to improve this PR is to use ZSH's condition syntax instead of an empty VENV variable:
(?..${VENV})
Thanks again for your effort to create this PR. Rejecting a PR is one of the harder parts as a project maintainer so I hope you understand my points.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for Python's Virtual environments to the ZSH prompt.
So far, I've updated only the code (it works). I want to see if there's interest in merging this before I update the comments and documentation.