Skip to content

chore(az.df): add cancellation token support for azure data factory test fixtures #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stijnmoreels wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(az.df): add cancellation token support for azure data factory test fixtures #516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/preview/03-Features/04-Azure/06-Integration/01-data-factory.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ ResourceIdentifier dataFactoryResourceId =
DataFactoryResource.CreateResourceIdentifier("<subscription-id>", "<resource-group>", "<factory-name>");

await using var session =
await TemporaryDataFlowDebugSession.StartDebugSessionAsync(dataFactoryResourceId, logger);
await TemporaryDataFlowDebugSession.StartDebugSessionAsync(dataFactoryResourceId, logger, cancellationToken);
```

> ⚡ Uses by default the `DefaultAzureCredential` but other types of authentication mechanism are supported with overloads that take in the `DataFactoryResource` directly:
Expand Down Expand Up @@ -193,7 +193,7 @@ using Arcus.Testing;
await using TemporaryDataFlowDebugSession session = ...

DataFlowRunResult result =
await session.RunDataFlowAsync("<dataflow-name>", "<target-sink-name>");
await session.RunDataFlowAsync("<dataflow-name>", "<target-sink-name>", cancellationToken);

// The run status of data preview, statistics or expression preview.
string status = result.Status;
Expand Down
6 changes: 5 additions & 1 deletion src/Arcus.Testing.Integration.DataFactory/Arcus.Testing.Integration.DataFactory.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,10 @@
<AnalysisMode>All</AnalysisMode>
</PropertyGroup>

<ItemGroup>
<Compile Include="..\ObsoleteDefaults.cs" Link="ObsoleteDefaults.cs" />
</ItemGroup>

<ItemGroup>
<None Include="..\..\README.md" Pack="true" PackagePath="\" />
<None Include="..\..\LICENSE" Pack="true" PackagePath="\" />
Expand All @@ -31,7 +35,7 @@
<ItemGroup>
<PackageReference Include="Azure.Identity" Version="[1.*,2.0.0)" />
<PackageReference Include="Azure.ResourceManager.DataFactory" Version="[1.*,2.0.0)" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="[8.*,11.0.0)" />
<PackageReference Include="Microsoft.Extensions.Logging.Abstractions" Version="[10.*,11.0.0)" />
</ItemGroup>

<ItemGroup>
Expand Down
Loading
Loading