feat: regenerate README screenshots from the functional tests - #190
Merged
Conversation
Adds a refreshReadmeScreenshots task that reruns the functional suite and copies each mapped test's screenshots into docs/images, and commits the refreshed images. The previous set dated from December 2022 and predates the remember-me checkbox and the consent Deny button.
GitHub scales README images down to its column width but never up, so the 1280x720 captures rendered at ~69% while carrying mostly whitespace. At 640x400 they render 1:1 and the form fills a meaningful share of the frame.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 2 of the visual walkthrough plan. Adds
refreshReadmeScreenshots: a documentation task that reruns the functional suite and copies each mapped test's screenshots into docs/images (delete-then-copy per flow, with a clear failure if a test rename breaks the mapping). Also commits the refreshed images for both README flows — the committed set dated from December 2022 and predates the remember-me checkbox and the consent Deny button, so the README was showing a UI that no longer exists. Filenames are unchanged, so the README's existing image references stay valid.Second commit shrinks the pinned viewport from 1280x720 to 640x400 and regenerates: GitHub scales README images down to its ~880px column but never up, so the old size rendered at ~69% while carrying mostly whitespace; at 640x400 the captures render 1:1. This is the plain-copy version; the compare-before-copy threshold and --force override come next.