feat(reference-app): style the pages with Pico and make the consent screen realistic - #191
Closed
ardetrick wants to merge 3 commits into
Closed
feat(reference-app): style the pages with Pico and make the consent screen realistic#191ardetrick wants to merge 3 commits into
ardetrick wants to merge 3 commits into
Conversation
…g pages Vendors Pico v2.1.1 as static/pico.min.css and restyles the pages as a centered card. Login now pre-fills the demo credentials with a caption so they are obvious. Page titles are normalized to h1, and the screenshot viewport is pinned to 576x520 so captures are a uniform, GitHub-column-friendly size.
…sures The callback page leads with a prominent Exchange button and an honest note that a real app does this server-side; the raw authorization code and the client credentials move into <details> disclosures. The tokens page leads with a success line and tucks the raw token response and decoded claims behind disclosures. This keeps the variable-length, non-deterministic content out of the default view so every screen is a fixed size.
…n consent The consent screen now reads like a real client's: it names the requesting application and shows a plain-language description for each scope (with the raw scope name alongside), sourced from the consent challenge. Adds a RequestedScope catalog for the descriptions. Drops the redundant 'offline' scope, and gives the test clients a stable client_name so the screen is deterministic. Regenerates the README screenshots.
Owner
Author
|
Superseded by three stacked single-commit PRs so each lands as its own squash commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restyles the reference app's login, consent, logout, callback, tokens, and landing pages with vendored Pico CSS (v2.1.1) as a clean centered card, and reworks the content so the pages read like a real client would build them.
Highlights:
offlinescope is dropped.Split into three reviewable commits (Pico styling / collapse variable content / consent enhancement), each building green on its own.
Known follow-up: the three "after-consent-submit" images are still the functional tests' echo-endpoint captures (a random code, unstyled). A later change will re-source the README walkthrough from the /demo flow, replacing them with the styled, deterministic callback and tokens pages.