Fix Provisioning 2.0 sketch for production of Opta Lite and Opta rs485#594
Open
fabik111 wants to merge 2 commits intoarduino-libraries:masterfrom
Open
Fix Provisioning 2.0 sketch for production of Opta Lite and Opta rs485#594fabik111 wants to merge 2 commits intoarduino-libraries:masterfrom
fabik111 wants to merge 2 commits intoarduino-libraries:masterfrom
Conversation
|
Memory usage change @ 2493531
Click for full report table
Click for full report CSV |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #594 +/- ##
=======================================
Coverage 94.73% 94.73%
=======================================
Files 32 32
Lines 1482 1482
=======================================
Hits 1404 1404
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Memory usage change @ 105d87c
Click for full report table
Click for full report CSV |
105d87c to
2230e85
Compare
|
Memory usage change @ 2c5a1ab
Click for full report table
Click for full report CSV |
924e4dc to
d21ba39
Compare
Contributor
|
Moved the check for wifi module presence in Connection Handler library: arduino-libraries/Arduino_ConnectionHandler#165 |
d21ba39 to
4fa31fb
Compare
|
Memory usage change @ 4fa31fb
Click for full report table
Click for full report CSV |
4fa31fb to
10bb111
Compare
Contributor
|
This PR requires arduino/ArduinoCore-mbed#1110 to be released in order to properly work |
10bb111 to
d272f71
Compare
|
Memory usage change @ d272f71
Click for full report table
Click for full report CSV |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the Opta Lite and Opta RS485 are not equipped with the WiFi module, the factory doesn't upload the WiFi FW file, but only adds the partition to store it. So, the board at the production test stage triggered the partition of the QSPI flash. This was not expected.
Changes: