Skip to content

Commit 1c65703

Browse files
Merge pull request #160 from andreagilardoni/nc-removal
Removing Notecard references from repo
2 parents f338e51 + 0fd2c2d commit 1c65703

3 files changed

Lines changed: 6 additions & 8 deletions

File tree

src/ConnectionHandlerInterface.h

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,17 +48,15 @@ class ConnectionHandler {
4848

4949
virtual NetworkConnectionState check();
5050

51-
#if not defined(BOARD_HAS_LORA)
52-
virtual unsigned long getTime() = 0;
53-
#endif
54-
55-
#if defined(BOARD_HAS_NOTECARD) || defined(BOARD_HAS_LORA)
51+
#if defined(BOARD_HAS_LORA)
5652
virtual bool available() = 0;
5753
virtual int read() = 0;
5854
virtual int write(const uint8_t *buf, size_t size) = 0;
5955
#else
6056
virtual Client &getClient() = 0;
6157
virtual UDP &getUDP() = 0;
58+
59+
virtual unsigned long getTime() = 0;
6260
#endif
6361

6462
NetworkConnectionState getStatus() __attribute__((deprecated)) {

src/GenericConnectionHandler.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ NetworkConnectionState GenericConnectionHandler::update_handleDisconnected() {
7878
return _ch != nullptr ? _ch->update_handleDisconnected() : NetworkConnectionState::INIT;
7979
}
8080

81-
#if not (defined(BOARD_HAS_LORA) or defined(BOARD_HAS_NOTECARD))
81+
#if !defined(BOARD_HAS_LORA)
8282
unsigned long GenericConnectionHandler::getTime() {
8383
return _ch != nullptr ? _ch->getTime() : 0;
8484
}
@@ -91,7 +91,7 @@ UDP & GenericConnectionHandler::getUDP() {
9191
return _ch->getUDP(); // NOTE _ch may be nullptr
9292
}
9393

94-
#endif // not (defined(BOARD_HAS_LORA) or defined(BOARD_HAS_NOTECARD))
94+
#endif // defined(BOARD_HAS_LORA)
9595

9696
void GenericConnectionHandler::connect() {
9797
if(_ch!=nullptr) {

src/GenericConnectionHandler.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ class GenericConnectionHandler : public ConnectionHandler
3131

3232
GenericConnectionHandler(bool const keep_alive=true): ConnectionHandler(keep_alive), _ch(nullptr) {}
3333

34-
#if defined(BOARD_HAS_NOTECARD) || defined(BOARD_HAS_LORA)
34+
#if defined(BOARD_HAS_LORA)
3535
virtual bool available() = 0;
3636
virtual int read() = 0;
3737
virtual int write(const uint8_t *buf, size_t size) = 0;

0 commit comments

Comments
 (0)