fix: GSMConnectionHandler stuck in ERROR state if connection lost (out of range)

Author: eigen-value

src/ConnectionHandlerInterface.cpp

@@ -78,7 +78,7 @@ NetworkConnectionState ConnectionHandler::updateConnectionState() {
     case NetworkConnectionState::CONNECTED:     next_net_connection_state = update_handleConnected    (); break;
     case NetworkConnectionState::DISCONNECTING: next_net_connection_state = update_handleDisconnecting(); break;
     case NetworkConnectionState::DISCONNECTED:  next_net_connection_state = update_handleDisconnected (); break;
-    case NetworkConnectionState::ERROR:                                                                   break;
+    case NetworkConnectionState::ERROR:         next_net_connection_state = update_handleError        (); break;
     case NetworkConnectionState::CLOSED:                                                                  break;
   }
 

src/ConnectionHandlerInterface.h

@@ -124,6 +124,7 @@ class ConnectionHandler {
     virtual NetworkConnectionState update_handleConnected    () = 0;
     virtual NetworkConnectionState update_handleDisconnecting() = 0;
     virtual NetworkConnectionState update_handleDisconnected () = 0;
+    virtual NetworkConnectionState update_handleError        () = 0;
 
     models::NetworkSetting _settings;
 

src/GSMConnectionHandler.cpp

@@ -160,4 +160,14 @@ NetworkConnectionState GSMConnectionHandler::update_handleDisconnected()
   }
 }
 
+NetworkConnectionState GSMConnectionHandler::update_handleError()
+{
+  if (_keep_alive)  {
+    return NetworkConnectionState::INIT;
+  }
+
+  return NetworkConnectionState::ERROR;
+
+}
+
 #endif /* #ifdef BOARD_HAS_GSM  */

src/GSMConnectionHandler.h

@@ -50,6 +50,7 @@ class GSMConnectionHandler : public ConnectionHandler
     virtual NetworkConnectionState update_handleConnected    () override;
     virtual NetworkConnectionState update_handleDisconnecting() override;
     virtual NetworkConnectionState update_handleDisconnected () override;
+    virtual NetworkConnectionState update_handleError        () override;
 
 
   private: