Merge branch 'main' into eth_wrapper_fix

Author: leonardocavagnis

.github/workflows/build.yml

@@ -26,7 +26,7 @@ jobs:
       # EXTRA_ZEPHYR_MODULES.
 
     steps:
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
         with:
           fetch-depth: 0
           persist-credentials: false

.github/workflows/format_check.yml

@@ -19,7 +19,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout code
-        uses: actions/checkout@v4
+        uses: actions/checkout@v6
         with:
           submodules: false
           persist-credentials: false

.github/workflows/package_core.yml

@@ -55,7 +55,7 @@ jobs:
           sudo apt-get update
           sudo apt-get install -y --no-install-recommends git cmake wget python3-pip ninja-build
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
         with:
           submodules: 'recursive'
           fetch-depth: 0
@@ -75,7 +75,7 @@ jobs:
         # needs the above env vars
         run: |
           echo "## Building \`$CORE_VER\`" >> "$GITHUB_STEP_SUMMARY"
-          echo "CORE_TAG=$(git describe --tags --exact-match 2>/dev/null || echo $CORE_HASH)" >> "$GITHUB_ENV"
+          echo "CORE_TAG=$(git describe --tags --exact-match --exclude '*/*' 2>/dev/null || echo $CORE_HASH)" >> "$GITHUB_ENV"
           echo "ALL_BOARD_FQBNS=$(jq -c 'map((. + {link_mode: "static"}), (. + {link_mode: "dynamic"}))' <<< ${ALL_BOARD_DATA})" >> "$GITHUB_ENV"
           echo "ARTIFACTS=$(jq -c '["zephyr"] + (map(.artifact) | unique)' <<< ${ALL_BOARD_DATA})" >> "$GITHUB_ENV"
           echo "SUB_ARCHES=$(jq -c 'map(.subarch) | unique' <<< ${ALL_BOARD_DATA})" >> "$GITHUB_ENV"
@@ -85,18 +85,20 @@ jobs:
           tar cphf - cores/arduino/api | zstd > arduino-api.tar.zstd
 
       - name: Archive build environment
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: build-env
           path: ~/build-env.tar.zstd
           retention-days: 1
+          archive: false
 
       - name: Archive API snapshot
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: arduino-api
           path: arduino-api.tar.zstd
           retention-days: 1
+          archive: false
 
 
 
@@ -124,10 +126,10 @@ jobs:
       fail-fast: false
     steps:
 
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v8
         with:
           path: /home/runner
-          name: build-env
+          name: build-env.tar.zstd
 
       - name: Restore build environment
         run: |
@@ -137,7 +139,7 @@ jobs:
           (cd ~ && tar --use-compress-program=unzstd -xpf build-env.tar.zstd && rm build-env.tar.zstd)
 
       - name: ccache
-        uses: hendrikmuhs/ccache-action@v1.2
+        uses: hendrikmuhs/ccache-action@v1.2.21
         with:
           verbose: 1
           key: ${{ github.job }}-${{ matrix.board }} # independent caches
@@ -191,16 +193,17 @@ jobs:
 
       - name: Archive board binaries
         if: ${{ !cancelled() }}
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           # prefix the name with 'failed-' if the build failed, so that it is not removed
           name: ${{ format('{0}binaries-{1}', (job.status == 'failure') && 'failed-' || '', env.ARTIFACT_TAG) }}
           path: binaries-${{ env.ARTIFACT_TAG }}.tar.zstd
           retention-days: 7 # for failed build inspection
+          archive: false
 
       - name: Archive build reports
         if: ${{ !cancelled() }}
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: build-report-${{ env.ARTIFACT_TAG }}
           path: ${{ env.REPORT_FILES }}
@@ -221,7 +224,7 @@ jobs:
       - build-board
     env:
       ALL_BOARD_DATA: ${{ needs.build-env.outputs.ALL_BOARD_DATA }}
-      CORE_ARTIFACT: ArduinoCore-${{ matrix.artifact }}-${{ needs.build-env.outputs.CORE_HASH }}
+      CORE_ARTIFACT: ArduinoCore-${{ matrix.artifact }}-${{ needs.build-env.outputs.CORE_HASH }}.tar.bz2
       CORE_TAG: ${{ needs.build-env.outputs.CORE_TAG }}
     strategy:
       matrix:
@@ -230,21 +233,21 @@ jobs:
     if: ${{ !cancelled() && needs.build-env.result == 'success' }}
     steps:
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
         with:
           submodules: 'recursive'
           fetch-depth: 0
           persist-credentials: false
           fetch-tags: true
 
       # Get the API snapshot
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v8
         with:
           path: .
-          name: arduino-api
+          name: arduino-api.tar.zstd
 
       # Get all built binaries
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v8
         with:
           path: .
           pattern: binaries-*
@@ -259,13 +262,14 @@ jobs:
             tar --use-compress-program=unzstd -xpf $f
           done
           # Create the core artifact for this set of boards
-          ./extra/package_core.sh ${{ matrix.artifact }} ${CORE_TAG} distrib/${CORE_ARTIFACT}.tar.bz2
+          ./extra/package_core.sh ${{ matrix.artifact }} ${CORE_TAG} distrib/${CORE_ARTIFACT}
 
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@v7
         if: ${{ success() || failure() }}
         with:
           name: ${{ env.CORE_ARTIFACT }}
-          path: distrib/${{ env.CORE_ARTIFACT }}.tar.bz2
+          path: distrib/${{ env.CORE_ARTIFACT }}
+          archive: false
 
 
 
@@ -279,12 +283,12 @@ jobs:
       - package-core
     steps:
 
-      - uses: geekyeggo/delete-artifact@v5.1.0
+      - uses: geekyeggo/delete-artifact@v6
         with:
           name: |
-            arduino-api
+            arduino-api.tar.zstd
             binaries-*
-            build-env
+            build-env.tar.zstd
           failOnError: false
 
 
@@ -308,27 +312,27 @@ jobs:
     env:
       PLAT: arduino:${{ matrix.subarch }}
       FQBN: arduino:${{ matrix.subarch }}:${{ matrix.board }}:link_mode=${{ matrix.link_mode }}
-      CORE_ARTIFACT: ArduinoCore-${{ matrix.artifact }}-${{ needs.build-env.outputs.CORE_HASH }}
+      CORE_ARTIFACT: ArduinoCore-${{ matrix.artifact }}-${{ needs.build-env.outputs.CORE_HASH }}.tar.bz2
       ARTIFACT_TAG: ${{ needs.build-env.outputs.CORE_HASH }}-${{ matrix.board }}-${{ matrix.link_mode }}
     if: ${{ !cancelled() && needs.build-env.result == 'success' }}
     steps:
 
       # only needs the test list generator and artifact information
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
         with:
           fetch-depth: 0
           persist-credentials: false
           sparse-checkout: |
             extra/ci_test_list.sh
             extra/artifacts/
 
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v8
         with:
           name: ${{ env.CORE_ARTIFACT }}
 
       - name: Set up core
         run: |
-          tar xf ${CORE_ARTIFACT}.tar.bz2 # will create ArduinoCore-zephyr/
+          tar xf ${CORE_ARTIFACT} # will create ArduinoCore-zephyr/
           echo "REPORT_FILE=$(echo ${FQBN} | tr ':' '-').json" >> $GITHUB_ENV
 
       - name: Get test sketches
@@ -337,7 +341,7 @@ jobs:
           extra/ci_test_list.sh ${{ matrix.artifact }} ${{ matrix.variant }}
 
       - name: Compile tests for ${{ matrix.board }}
-        uses: pillo79/compile-sketches@4a1dead03155c17ddedc373699d7aa80a78a6c7d # next
+        uses: pillo79/compile-sketches@next
         with:
           fqbn: ${{ env.FQBN }}
           platforms: |
@@ -369,7 +373,7 @@ jobs:
           sed -i -e 's!/home/runner/.arduino15/packages/arduino/hardware/zephyr/[^/]*/!!g' sketches-reports/${REPORT_FILE}
 
       # archive the compile report for later
-      - uses: actions/upload-artifact@v4
+      - uses: actions/upload-artifact@v7
         if: ${{ success() || failure() }}
         with:
           name: test-report-${{ env.ARTIFACT_TAG }}
@@ -395,23 +399,25 @@ jobs:
       GH_REPO: ${{ github.repository }}
     steps:
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
         with:
           fetch-depth: 0
           persist-credentials: false
           fetch-tags: true
 
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v8
         with:
           path: .
           pattern: "*-report-*"
           merge-multiple: true
 
-      - run: |
+      - name: Generate workflow summary
+        run: |
           # gather the array of job metadata (especially name and ID) for the current workflow run
           export WORKFLOW_JOBS=$(gh run view ${{ github.run_id }} --attempt ${{ github.run_attempt }} --json jobs --jq '.jobs')
           # Run the log inspection script
           extra/ci_inspect_logs.py result summary full_log
+          cat result
 
           # Display the summary and full log in the step summary
           cat summary >> $GITHUB_STEP_SUMMARY
@@ -426,15 +432,45 @@ jobs:
             cat summary | sed -e 's!\${\\color{\S*}\(.*\)}\$!\1!g' -e 's!\\%!%!g' >> comment-request/comment_body
           fi
 
+          # Prepare latest size artifact file on push events
+          if [ "${{ github.event_name }}" == "push" ]; then
+            tar jchf size-reports-${{ needs.build-env.outputs.CORE_HASH }}.tar.bz2 arduino-*.json
+          fi
+
+      - name: Compute code size changes
+        if: ${{ github.event_name == 'pull_request' }}
+        run: |
+          export GITHUB_BASE_SHA=$(git describe --always origin/${GITHUB_BASE_REF})
+          extra/ci_calc_size_reports.py ${GITHUB_BASE_SHA} sketches-reports/
+
       # upload comment request artifact (will be retrieved by leave_pr_comment.yml)
       - name: Archive comment information
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         if: ${{ github.event_name == 'pull_request' }}
         with:
           name: comment-request
           path: comment-request/
           retention-days: 1
 
+      # upload size delta report artifact (will be retrieved by report_size_deltas.yml)
+      - name: Archive size deltas report information
+        uses: actions/upload-artifact@v7
+        if: ${{ github.event_name == 'pull_request' }}
+        with:
+          name: sketches-reports
+          path: sketches-reports/
+          retention-days: 1
+
+      # upload new official test size artifact (for AWS storage)
+      - name: Archive sketch report information
+        uses: actions/upload-artifact@v7
+        if: ${{ github.event_name == 'push' }}
+        with:
+          name: size-reports
+          path: size-reports-${{ needs.build-env.outputs.CORE_HASH }}.tar.bz2
+          retention-days: 1
+          archive: false
+
       # The last line makes the job fail if the 'result' file does not contain "PASSED".
       # No further actions are allowed in case of error.
       - run: |
@@ -457,7 +493,7 @@ jobs:
     steps:
 
       - name: Clean up intermediate artifacts
-        uses: geekyeggo/delete-artifact@v5.1.0
+        uses: geekyeggo/delete-artifact@v6
         with:
           name: |
             build-report-*
@@ -482,14 +518,19 @@ jobs:
       contents: read
     steps:
 
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v8
         with:
           path: .
           pattern: ArduinoCore-*
           merge-multiple: true
 
+      - uses: actions/download-artifact@v8
+        with:
+          path: .
+          pattern: size-reports-*.tar.bz2
+
       - name: Configure AWS credentials
-        uses: aws-actions/configure-aws-credentials@v4
+        uses: aws-actions/configure-aws-credentials@v6
         with:
           role-to-assume: ${{ secrets.IAM_ROLE }}
           aws-region: ${{ secrets.AWS_REGION }}
@@ -499,6 +540,7 @@ jobs:
           for f in ArduinoCore-*.tar.bz2 ; do
             aws s3 cp $f s3://${{ secrets.S3_BUCKET }}/
           done
+          aws s3 cp size-reports-*.tar.bz2 s3://${{ secrets.S3_BUCKET }}/size-reports/
 
   # Prepare the package index JSON snippets for the newly built core packages.
 
@@ -515,13 +557,13 @@ jobs:
       ARTIFACTS: ${{ needs.build-env.outputs.ARTIFACTS }}
     steps:
 
-      - uses: actions/checkout@v4
+      - uses: actions/checkout@v6
         with:
           fetch-depth: 0
           persist-credentials: false
           fetch-tags: true
 
-      - uses: actions/download-artifact@v4
+      - uses: actions/download-artifact@v8
         with:
           path: .
           pattern: ArduinoCore-*
@@ -538,7 +580,7 @@ jobs:
           done
 
       - name: Archive package index snippets
-        uses: actions/upload-artifact@v4
+        uses: actions/upload-artifact@v7
         with:
           name: ArduinoCore-zephyr-${{ env.CORE_TAG }}-jsons
           path: ArduinoCore-*-${{ env.CORE_TAG }}.json