Merge pull request #365 from pillo79/ci-fix2

ci/package_core: cleanup test results only on positive result

Author: pillo79

.github/workflows/leave_pr_comment.yml

@@ -32,18 +32,18 @@ jobs:
       - name: Check PR number
         id: check-pr
         uses: carpentries/actions/check-valid-pr@2e20fd5ee53b691e27455ce7ca3b16ea885140e8 # v0.15.0
+        if: ${{ env.PR_NUM }}
         with:
           pr: ${{ env.PR_NUM }}
           sha: ${{ github.event.workflow_run.head_sha }}
 
       - name: Validate PR number
-        if: ${{ steps.check-pr.outputs.VALID != 'true' }}
+        if: ${{ env.PR_NUM && steps.check-pr.outputs.VALID != 'true' }}
         run: |
-          echo "::error::PR number $PR_NUM validation failed"
-          exit 1
+          echo "::warning::PR #$PR_NUM is either invalid or includes changes to workflow"
 
       - name: Update PR comment
-        if: ${{ steps.check-pr.outputs.VALID == 'true' }}
+        if: ${{ env.PR_NUM && steps.check-pr.outputs.VALID == 'true' }}
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
           GH_REPO: ${{ github.repository }}

.github/workflows/package_core.yml

@@ -435,7 +435,27 @@ jobs:
           path: comment-request/
           retention-days: 1
 
-      # teports are no longer needed now
+      # The last line makes the job fail if the 'result' file does not contain "PASSED".
+      # No further actions are allowed in case of error.
+      - run: |
+          cat result
+          grep -q "PASSED" result # otherwise CI test failed
+
+
+
+  # Clean up test results only if the verification actually passed, so that
+  # they are still available for action re-runs in case of failure.
+
+  clean-temps:
+    name: Clean up test results
+    runs-on: ubuntu-latest
+    if: ${{ needs.verify-core.result == 'success' }}
+    needs:
+      - build-env
+      - package-core
+      - verify-core
+    steps:
+
       - name: Clean up intermediate artifacts
         uses: geekyeggo/delete-artifact@v5.1.0
         with:
@@ -444,12 +464,6 @@ jobs:
             test-report-*
           failOnError: false
 
-      # The last line makes the job fail if the 'result' file does not contain "PASSED".
-      # No further actions are allowed in case of error.
-      - run: |
-          cat result
-          grep "PASSED" result >& /dev/null # otherwise CI test failed
-
 
 
   # Upload the built core packages to the S3 bucket for public distribution.