Skip to content

chore(deps): upgrade runtime dependencies and CI workflow#1206

Merged
garrett4wade merged 2 commits into
mainfrom
chore/upgrade-deps-2026-04
May 6, 2026
Merged

chore(deps): upgrade runtime dependencies and CI workflow#1206
garrett4wade merged 2 commits into
mainfrom
chore/upgrade-deps-2026-04

Conversation

@garrett4wade
Copy link
Copy Markdown
Collaborator

@garrett4wade garrett4wade commented Apr 18, 2026

Description

Upgrade megatron-core, sglang, vllm (0.19.1), transformers, and related packages.
Pin deepep/deepgemm commits and lock trackio version for reproducibility.
Optimize the Dockerfile, add a uv_sync.sh helper, and remove integration tests
from per-PR CI (moved to nightly).

Type of Change

  • ♻️ Refactoring

Key Changes

  • Dependencies: Upgrade sglang, vllm (pinned 0.19.1), transformers, megatron-core
  • vLLM compat: Remove unsupported args, fix worker extension for 0.19.1 API
  • SGLang: Refactor launch_server/scheduler for latest sglang API changes
  • Dockerfile: Slim image, optimize layer caching, fix uv install on Linux
  • Archon: Fix Qwen3.5 precision args and model config
  • Infra: Shrink port range, fix Ray utils, add engine blueprint guard
  • CI: Remove integration tests from PR workflow (moved to nightly)
  • Tests: Sync GRPO integration config, add agent_service controller test

Risk Areas

  • vLLM worker extension rewrite — behavioral change in weight update flow
  • SGLang scheduler refactor — changed server lifecycle management
  • Dockerfile restructure — could affect image build caching

Test Commands Run

pre-commit run --all-files  # All hooks pass (skipped generate-cli-docs: no local Python)

Integration tests (SFT, GRPO) require GPU hardware — deferred to nightly CI.

Checklist

  • I have read the Contributing Guide
  • Pre-commit hooks pass (pre-commit run --all-files)
  • Relevant tests pass; new tests added for new functionality
  • Documentation updated (if applicable; built with ./docs/build_all.sh)
  • Branch is up to date with main
  • Self-reviewed via /review-pr command
  • This PR was created by a coding agent via /create-pr
  • This PR is a breaking change

Additional Context

43 files changed, 4461 insertions(+), 2911 deletions(-).
Lock file churn accounts for the majority of the diff (uv.lock, uv.vllm.lock).

@garrett4wade garrett4wade requested a review from fishcrap as a code owner April 18, 2026 12:09
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new upgrade-deps skill and a comprehensive set of API compatibility checklists for core dependencies like megatron-core, transformers, sglang, and vllm. It updates several package versions in pyproject.toml and pyproject.vllm.toml, including a bump to megatron-core 0.17.0 and the addition of Python 3.12 version markers. Feedback identifies a missing architecture suffix in the Dockerfile base image and recommends consistent application of the Python 3.12 marker to the mbridge package across both project manifests.

Comment thread Dockerfile Outdated
Comment thread pyproject.toml Outdated
Comment thread pyproject.vllm.toml Outdated
@garrett4wade garrett4wade force-pushed the chore/upgrade-deps-2026-04 branch 2 times, most recently from 4470eaa to 9b09beb Compare April 19, 2026 09:00
@garrett4wade garrett4wade force-pushed the chore/upgrade-deps-2026-04 branch from 3b869e8 to b180e0c Compare April 20, 2026 09:44
@garrett4wade garrett4wade force-pushed the chore/upgrade-deps-2026-04 branch 2 times, most recently from 60a27d1 to 4b72815 Compare April 22, 2026 11:11
@garrett4wade garrett4wade force-pushed the chore/upgrade-deps-2026-04 branch 6 times, most recently from 83bff5d to e8c4606 Compare April 29, 2026 13:02
@garrett4wade garrett4wade changed the title chore(deps): upgrade megatron-core, megatron-bridge, sglang, vllm chore(deps): upgrade megatron-core, sglang, vllm, transformers Apr 29, 2026
@HT-Yuan
Copy link
Copy Markdown
Collaborator

HT-Yuan commented Apr 30, 2026

@garrett4wade
Hi, I'm working on adding Muon optimizer support (PR #1270) which depends on megatron-core >= 0.17.

I noticed this PR hasn't been merged yet — is there any blocking issue?

@garrett4wade
Copy link
Copy Markdown
Collaborator Author

@HT-Yuan Hi, the upgrade of megatron-core should not break anything, but in this PR we'd like to upgrade other packages as well, which involves some changes of the integration code. I think #1270 is parallel to this PR though. We can find someone review this PR when you are ready.

@garrett4wade garrett4wade temporarily deployed to AReaL-unittests May 4, 2026 13:44 — with GitHub Actions Inactive
@garrett4wade garrett4wade temporarily deployed to AReaL-unittests May 4, 2026 15:22 — with GitHub Actions Inactive
@garrett4wade garrett4wade temporarily deployed to AReaL-unittests May 5, 2026 08:32 — with GitHub Actions Inactive
@garrett4wade garrett4wade temporarily deployed to AReaL-unittests May 5, 2026 08:40 — with GitHub Actions Inactive
@garrett4wade garrett4wade temporarily deployed to AReaL-unittests May 5, 2026 08:40 — with GitHub Actions Inactive
Upgrade megatron-core, sglang, vllm (0.19.1), transformers,
and related packages. Pin deepep/deepgemm commits and lock
trackio version for reproducibility.

Key changes:
- Upgrade sglang, vllm, transformers, megatron-core versions
- Pin vllm to 0.19.1, fix compatibility across backends
- Optimize Dockerfile and slim Docker image
- Add uv_sync.sh install script, fix uv install on Linux
- Fix Archon Qwen3.5 precision and port range issues
- Remove integration tests from PR CI (moved to nightly)
- Sync GRPO integration test config

Refs: upgrade-deps branch
@garrett4wade garrett4wade force-pushed the chore/upgrade-deps-2026-04 branch from 9260438 to aedb4f4 Compare May 6, 2026 02:51
@garrett4wade garrett4wade changed the title chore(deps): upgrade megatron-core, sglang, vllm, transformers chore(deps): upgrade runtime dependencies and CI workflow May 6, 2026
@garrett4wade garrett4wade temporarily deployed to AReaL-unittests May 6, 2026 03:30 — with GitHub Actions Inactive
@garrett4wade
Copy link
Copy Markdown
Collaborator Author

@garrett4wade garrett4wade merged commit 8501ba2 into main May 6, 2026
18 checks passed
@garrett4wade garrett4wade deleted the chore/upgrade-deps-2026-04 branch May 6, 2026 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants