fix(test): add missing colocate field to wu_controller connect tests#1357
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the weight update controller tests in test_wu_controller.py by adding a colocate field, initialized to False, to the expected request payloads in both test_connect_sends_correct_request and test_connect_disk_mode_sends_disk_fields. I have no feedback to provide as there were no review comments to evaluate.
sitabulaixizawaluduo
requested review from
HwVanICI,
TaoZex,
fishcrap,
guozhihao-224,
nuzant and
rchardx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests in
test_wu_controller.py::TestConnectassert the exact JSON payload sent to/connect. #1310 added acolocatefield to the controller's payload but did not update these tests, breaking CI on main.