Skip to content

Resolve conflicts in src/backend/executor/nodeModifyTable.c#2573

Merged
RekGRpth merged 2 commits into
sync-14x-b13from
sync-14x-b13-13
May 29, 2026
Merged

Resolve conflicts in src/backend/executor/nodeModifyTable.c#2573
RekGRpth merged 2 commits into
sync-14x-b13from
sync-14x-b13-13

Conversation

@RekGRpth

Copy link
Copy Markdown
Member
  1. Commit a04daa9 in src/backend/executor/nodeModifyTable.c changed the
    comment before the ExecInsert function, but earlier GPDB-specific
    commits had already added a GPDB-specific comment in the same location.

  2. Commit a04daa9 in src/backend/executor/nodeModifyTable.c in the
    ExecDelete function deleted a couple of lines, but earlier
    GPDB-specific commits had already added a conditional error message
    before this location.

  3. Commit c5b097f in src/backend/executor/nodeModifyTable.c moved some
    code to the new ExecCrossPartitionUpdate function in the ExecUpdate
    function. However, the earlier commit 19cd1cf had already added the
    segid and splitUpdate arguments to the ExecDelete and ExecInsert
    functions in these same locations.

  4. Commit a04daa9 in src/backend/executor/nodeModifyTable.c removed the
    es_result_relation_info save in the ExecModifyTable function before
    calling the EvalPlanQualSetPlan function. However, earlier
    GPDB-specific commits had already added code before this location.

  5. Commit a04daa9 in src/backend/executor/nodeModifyTable.c added a new
    resultRelInfo argument to the ExecModifyTable function when calling
    ExecInsert ExecDelete. However, the earlier commit 19cd1cf had already
    added the splitUpdate argument to the ExecInsert function.

  6. Commit a04daa9 in src/backend/executor/nodeModifyTable.c added a new
    resultRelInfo argument to the ExecModifyTable function when calling
    ExecUpdate. However, earlier GPDB-specific commits had already added
    the code for split updates.

  7. Commit a04daa9 in file src/backend/executor/nodeModifyTable.c in
    function ExecModifyTable when calling function ExecDelete added new
    argument resultRelInfo, while earlier commit 19cd1cf already added
    arguments segid and splitUpdate, and commit 973cf25 already added
    conditional call of function ExecPrepareTupleRouting before and
    conditional saving of resultRelInfo after this place.

1) Commit a04daa9 in src/backend/executor/nodeModifyTable.c changed the
comment before the ExecInsert function, but earlier GPDB-specific
commits had already added a GPDB-specific comment in the same location.

2) Commit a04daa9 in src/backend/executor/nodeModifyTable.c in the
ExecDelete function deleted a couple of lines, but earlier
GPDB-specific commits had already added a conditional error message
before this location.

3) Commit c5b097f in src/backend/executor/nodeModifyTable.c moved some
code to the new ExecCrossPartitionUpdate function in the ExecUpdate
function. However, the earlier commit 19cd1cf had already added the
segid and splitUpdate arguments to the ExecDelete and ExecInsert
functions in these same locations.

4) Commit a04daa9 in src/backend/executor/nodeModifyTable.c removed the
es_result_relation_info save in the ExecModifyTable function before
calling the EvalPlanQualSetPlan function. However, earlier
GPDB-specific commits had already added code before this location.

5) Commit a04daa9 in src/backend/executor/nodeModifyTable.c added a new
resultRelInfo argument to the ExecModifyTable function when calling
ExecInsert ExecDelete. However, the earlier commit 19cd1cf had already
added the splitUpdate argument to the ExecInsert function.

6) Commit a04daa9 in src/backend/executor/nodeModifyTable.c added a new
resultRelInfo argument to the ExecModifyTable function when calling
ExecUpdate. However, earlier GPDB-specific commits had already added
the code for split updates.

7) Commit a04daa9 in file src/backend/executor/nodeModifyTable.c in
function ExecModifyTable when calling function ExecDelete added new
argument resultRelInfo, while earlier commit 19cd1cf already added
arguments segid and splitUpdate, and commit 973cf25 already added
conditional call of function ExecPrepareTupleRouting before and
conditional saving of resultRelInfo after this place.
Comment thread src/backend/executor/nodeModifyTable.c Outdated
@silent-observer

Copy link
Copy Markdown

Should we also remove a few GPDB-specific uses of it, while we're at it? There are a few mentions in copy.c, aocs_compaction.c and appendonly_compaction.c

@RekGRpth

Copy link
Copy Markdown
Member Author

Should we also remove a few GPDB-specific uses of it, while we're at it? There are a few mentions in copy.c, aocs_compaction.c and appendonly_compaction.c

I think this should be done in a separate PR (when the compilation is fixing), as the current PR is already quite complex, and it's about resolving conflicts in a one specific file.

@RekGRpth RekGRpth merged commit 8f79887 into sync-14x-b13 May 29, 2026
1 check passed
@RekGRpth RekGRpth deleted the sync-14x-b13-13 branch May 29, 2026 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants