Resolve conflicts in src/backend/executor/nodeModifyTable.c#2573
Merged
Conversation
1) Commit a04daa9 in src/backend/executor/nodeModifyTable.c changed the comment before the ExecInsert function, but earlier GPDB-specific commits had already added a GPDB-specific comment in the same location. 2) Commit a04daa9 in src/backend/executor/nodeModifyTable.c in the ExecDelete function deleted a couple of lines, but earlier GPDB-specific commits had already added a conditional error message before this location. 3) Commit c5b097f in src/backend/executor/nodeModifyTable.c moved some code to the new ExecCrossPartitionUpdate function in the ExecUpdate function. However, the earlier commit 19cd1cf had already added the segid and splitUpdate arguments to the ExecDelete and ExecInsert functions in these same locations. 4) Commit a04daa9 in src/backend/executor/nodeModifyTable.c removed the es_result_relation_info save in the ExecModifyTable function before calling the EvalPlanQualSetPlan function. However, earlier GPDB-specific commits had already added code before this location. 5) Commit a04daa9 in src/backend/executor/nodeModifyTable.c added a new resultRelInfo argument to the ExecModifyTable function when calling ExecInsert ExecDelete. However, the earlier commit 19cd1cf had already added the splitUpdate argument to the ExecInsert function. 6) Commit a04daa9 in src/backend/executor/nodeModifyTable.c added a new resultRelInfo argument to the ExecModifyTable function when calling ExecUpdate. However, earlier GPDB-specific commits had already added the code for split updates. 7) Commit a04daa9 in file src/backend/executor/nodeModifyTable.c in function ExecModifyTable when calling function ExecDelete added new argument resultRelInfo, while earlier commit 19cd1cf already added arguments segid and splitUpdate, and commit 973cf25 already added conditional call of function ExecPrepareTupleRouting before and conditional saving of resultRelInfo after this place.
|
Should we also remove a few GPDB-specific uses of it, while we're at it? There are a few mentions in |
Member
Author
I think this should be done in a separate PR (when the compilation is fixing), as the current PR is already quite complex, and it's about resolving conflicts in a one specific file. |
silent-observer
approved these changes
May 25, 2026
KnightMurloc
approved these changes
May 28, 2026
bimboterminator1
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit a04daa9 in src/backend/executor/nodeModifyTable.c changed the
comment before the ExecInsert function, but earlier GPDB-specific
commits had already added a GPDB-specific comment in the same location.
Commit a04daa9 in src/backend/executor/nodeModifyTable.c in the
ExecDelete function deleted a couple of lines, but earlier
GPDB-specific commits had already added a conditional error message
before this location.
Commit c5b097f in src/backend/executor/nodeModifyTable.c moved some
code to the new ExecCrossPartitionUpdate function in the ExecUpdate
function. However, the earlier commit 19cd1cf had already added the
segid and splitUpdate arguments to the ExecDelete and ExecInsert
functions in these same locations.
Commit a04daa9 in src/backend/executor/nodeModifyTable.c removed the
es_result_relation_info save in the ExecModifyTable function before
calling the EvalPlanQualSetPlan function. However, earlier
GPDB-specific commits had already added code before this location.
Commit a04daa9 in src/backend/executor/nodeModifyTable.c added a new
resultRelInfo argument to the ExecModifyTable function when calling
ExecInsert ExecDelete. However, the earlier commit 19cd1cf had already
added the splitUpdate argument to the ExecInsert function.
Commit a04daa9 in src/backend/executor/nodeModifyTable.c added a new
resultRelInfo argument to the ExecModifyTable function when calling
ExecUpdate. However, earlier GPDB-specific commits had already added
the code for split updates.
Commit a04daa9 in file src/backend/executor/nodeModifyTable.c in
function ExecModifyTable when calling function ExecDelete added new
argument resultRelInfo, while earlier commit 19cd1cf already added
arguments segid and splitUpdate, and commit 973cf25 already added
conditional call of function ExecPrepareTupleRouting before and
conditional saving of resultRelInfo after this place.