Merge tag '8.0.0-alpha.0' into claude-merge-1#2578
Draft
dimoffon wants to merge 1 commit into
Draft
Conversation
The beginning of ggdb 8 development. Just enough to pass the basic test set. Fix all compilation errors introduced by the PG13 API changes: List API changes (PG13): - lnext(cell) -> lnext(list, cell) throughout src/, contrib/, gpcontrib/, and unit test files (lsyscache_test.c, fixedwidth.c, extaccess.c, etc.) - for_each_cell(cell, initcell) -> for_each_cell(cell, list, initcell) - list_delete_cell(list, cell, prev) -> list_delete_cell(list, cell) or foreach_delete_current(list, cell) inside foreach loops; remove prev tracking - list_qsort(list, cmp) -> list_sort(list, cmp); list_sort returns void, so drop any assignment of its return value - lappend_cell(list, prev, datum) removed; replace with lappend(list, datum) - ListCell is now a flat union: cell->data.ptr_value -> cell->ptr_value ORCA C++ wrappers (src/include/gpopt/gpdbwrappers.h): - Remove 'struct ListCell;' forward declaration (ListCell is now a union) - Update ForEach, ForBoth, ForThree, ForEachWithCount macros to 2-arg lnext Storage manager vtable (src/backend/storage/smgr/smgr.c): - smgr_open removed from f_smgr vtable; call mdopen(reln) directly Base64 API (PG13 added dstlen parameter): - pg_b64_encode(src, len, dst) -> pg_b64_encode(src, len, dst, dstlen) - pg_b64_decode(src, len, dst) -> pg_b64_decode(src, len, dst, dstlen) Catalog OID conflicts: - AO_ROW_TABLE_AM_HANDLER_OID reassigned 4187->4142 (upstream took 4187) - AO_COLUMN_TABLE_AM_HANDLER_OID reassigned 4188->4191 (upstream took 4188) - Bump CATALOG_VERSION_NO to 302605201 Header cleanup: - src/bin/scripts/common.h: remove duplicate appendQualifiedRelation declaration left by conflict resolution (4-arg vs 5-arg forms) Build script: - concourse/scripts/compile_gpdb.bash: guard 'git describe --tags' with '|| true' and skip changelog generation when no tags are reachable Merge rules documentation: - GG_PG_MERGE_RULES.md: add all newly discovered patterns to the error table and verification checklist Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The beginning of ggdb 8 development. Just enough to pass the basic test set.
Fix all compilation errors introduced by the PG13 API changes:
List API changes (PG13):
ORCA C++ wrappers (src/include/gpopt/gpdbwrappers.h):
Storage manager vtable (src/backend/storage/smgr/smgr.c):
Base64 API (PG13 added dstlen parameter):
Catalog OID conflicts:
Header cleanup:
Build script:
Merge rules documentation:
Here are some reminders before you submit the pull request
make installcheck