fix: memoize outputs null in steps and dag templates

When a steps or DAG template with memoize and outputs completes,
the node is only re-fetched inside the 'if outputs != nil' block.
The subsequent c.Save() call uses the same local node variable,
so if outputs is nil, node.Outputs is stale/nil and 'outputs:null'
gets written to the ConfigMap cache.

Fix: always re-fetch the node unconditionally before the outputs
assignment and cache save, so c.Save() always uses the latest
node.Outputs from the store.

Fixes: steps.go and dag.go
Signed-off-by: om7057 <kulkarniom7057@gmail.com>

Author: om7057

workflow/controller/dag.go

@@ -366,12 +366,12 @@ func (woc *wfOperationCtx) executeDAG(ctx context.Context, nodeName string, tmpl
 		woc.log.Error(ctx, "unable to get outputs")
 		return node, err
 	}
+	node, err = woc.wf.GetNodeByName(nodeName)
+	if err != nil {
+		woc.log.WithField("nodeName", nodeName).Error(ctx, "unable to get node by name for nodeName")
+		return nil, err
+	}
 	if outputs != nil {
-		node, err = woc.wf.GetNodeByName(nodeName)
-		if err != nil {
-			woc.log.WithField("nodeName", nodeName).Error(ctx, "unable to get node by name for nodeName")
-			return nil, err
-		}
 		node.Outputs = outputs
 		woc.wf.Status.Nodes.Set(ctx, node.ID, *node)
 	}

workflow/controller/steps.go

@@ -199,11 +199,11 @@ func (woc *wfOperationCtx) executeSteps(ctx context.Context, nodeName string, tm
 		return node, err
 	}
 
+	node, err = woc.wf.GetNodeByName(nodeName)
+	if err != nil {
+		return nil, err
+	}
 	if outputs != nil {
-		node, err = woc.wf.GetNodeByName(nodeName)
-		if err != nil {
-			return nil, err
-		}
 		node.Outputs = outputs
 		woc.addOutputsToGlobalScope(ctx, node.Outputs)
 		woc.wf.Status.Nodes.Set(ctx, node.ID, *node)