@@ -1642,7 +1642,7 @@ func (s *FunctionalSuite) TestWorkflowInvalidServiceAccountError() {
16421642// the cache ConfigMap contains actual output values and NOT null.
16431643func (s * FunctionalSuite ) TestDAGMemoizeCacheOutputsNotNull () {
16441644 var cacheConfigMapName = "dag-memo-regression-cache"
1645-
1645+
16461646 s .Given ().
16471647 Workflow (`apiVersion: argoproj.io/v1alpha1
16481648kind: Workflow
@@ -1656,7 +1656,7 @@ spec:
16561656 tasks:
16571657 - name: memo-task
16581658 template: memoized-dag
1659-
1659+
16601660 - name: memoized-dag
16611661 dag:
16621662 tasks:
@@ -1673,7 +1673,7 @@ spec:
16731673 cache:
16741674 configMap:
16751675 name: dag-memo-regression-cache
1676-
1676+
16771677 - name: hello
16781678 outputs:
16791679 parameters:
@@ -1690,7 +1690,7 @@ spec:
16901690 Then ().
16911691 ExpectWorkflow (func (t * testing.T , metadata * metav1.ObjectMeta , status * wfv1.WorkflowStatus ) {
16921692 assert .Equal (t , wfv1 .WorkflowSucceeded , status .Phase )
1693-
1693+
16941694 // Find the memoized node
16951695 var memoizedNode * wfv1.NodeStatus
16961696 for _ , node := range status .Nodes {
@@ -1716,18 +1716,18 @@ spec:
17161716 cm , err := s .KubeClient .CoreV1 ().ConfigMaps (fixtures .Namespace ).Get (ctx , cacheConfigMapName , metav1.GetOptions {})
17171717 require .NoError (t , err , "should be able to get cache ConfigMap" )
17181718 require .NotNil (t , cm , "cache ConfigMap should exist" )
1719-
1719+
17201720 // Check the data field contains cache entries
17211721 require .NotEmpty (t , cm .Data , "cache ConfigMap should have data" )
1722-
1722+
17231723 // Verify the cache entry contains actual outputs, not null
17241724 // The bug would cause "outputs":null in the cache
17251725 // With the fix, actual outputs should be present
17261726 cacheData := ""
17271727 for _ , v := range cm .Data {
17281728 cacheData += v
17291729 }
1730-
1730+
17311731 assert .NotContains (t , cacheData , `"outputs":null` ,
17321732 "REGRESSION #16094: Cache should NOT contain null outputs" )
17331733 assert .Contains (t , cacheData , `"outputs":` ,
@@ -1742,7 +1742,7 @@ spec:
17421742// the cache ConfigMap contains actual output values and NOT null.
17431743func (s * FunctionalSuite ) TestStepsMemoizeCacheOutputsNotNull () {
17441744 var cacheConfigMapName = "steps-memo-regression-cache"
1745-
1745+
17461746 s .Given ().
17471747 Workflow (`apiVersion: argoproj.io/v1alpha1
17481748kind: Workflow
@@ -1755,7 +1755,7 @@ spec:
17551755 steps:
17561756 - - name: memo-step
17571757 template: memoized-steps
1758-
1758+
17591759 - name: memoized-steps
17601760 steps:
17611761 - - name: child-step
@@ -1771,7 +1771,7 @@ spec:
17711771 cache:
17721772 configMap:
17731773 name: steps-memo-regression-cache
1774-
1774+
17751775 - name: hello
17761776 outputs:
17771777 parameters:
@@ -1788,7 +1788,7 @@ spec:
17881788 Then ().
17891789 ExpectWorkflow (func (t * testing.T , metadata * metav1.ObjectMeta , status * wfv1.WorkflowStatus ) {
17901790 assert .Equal (t , wfv1 .WorkflowSucceeded , status .Phase )
1791-
1791+
17921792 // Find the memoized node
17931793 var memoizedNode * wfv1.NodeStatus
17941794 for _ , node := range status .Nodes {
@@ -1814,18 +1814,18 @@ spec:
18141814 cm , err := s .KubeClient .CoreV1 ().ConfigMaps (fixtures .Namespace ).Get (ctx , cacheConfigMapName , metav1.GetOptions {})
18151815 require .NoError (t , err , "should be able to get cache ConfigMap" )
18161816 require .NotNil (t , cm , "cache ConfigMap should exist" )
1817-
1817+
18181818 // Check the data field contains cache entries
18191819 require .NotEmpty (t , cm .Data , "cache ConfigMap should have data" )
1820-
1820+
18211821 // Verify the cache entry contains actual outputs, not null
18221822 // The bug would cause "outputs":null in the cache
18231823 // With the fix, actual outputs should be present
18241824 cacheData := ""
18251825 for _ , v := range cm .Data {
18261826 cacheData += v
18271827 }
1828-
1828+
18291829 assert .NotContains (t , cacheData , `"outputs":null` ,
18301830 "REGRESSION #16094: Cache should NOT contain null outputs" )
18311831 assert .Contains (t , cacheData , `"outputs":` ,
0 commit comments