fix: enable AllowNativePasswords for MariaDB authentication. Fixes #15413

Signed-off-by: Mario Apostolov <mario.apostolov@mariadb.com>

Author: mariadb-MarioEApostolov

.spelling

@@ -90,6 +90,7 @@ Lifecycle-Hook
 LitmusChaos
 MLOps
 Makefile
+MariaDB
 Metaflow
 MinIO
 Minikube

docs/workflow-archive.md

@@ -2,7 +2,7 @@
 
 > v2.5 and after
 
-If you want to keep completed workflows for a long time, you can use the workflow archive to save them in a Postgres (>=9.4) or MySQL (>= 5.7.8) database.
+If you want to keep completed workflows for a long time, you can use the workflow archive to save them in a Postgres (>=9.4), MySQL (>= 5.7.8), or MariaDB (>= 10.2) database.
 The workflow archive stores the status of the workflow, which pods have been executed, what was the result etc.
 The job logs of the workflow pods will not be archived.
 If you need to save the logs of the pods, you must setup an [artifact repository](artifact-repository-ref.md) according to [this doc](configure-artifact-repository.md).

util/sqldb/sqldb.go

@@ -196,13 +196,14 @@ func createPostGresDBSessionWithCreds(cfg *config.PostgreSQLConfig, persistPool
 func createMySQLDBSessionWithCreds(cfg *config.MySQLConfig, persistPool *config.ConnectionPool, username, password string) (db.Session, error) {
 	// Build MySQL DSN using mysql.Config to safely handle special characters in credentials
 	mysqlCfg := mysql.Config{
-		User:      username,
-		Passwd:    password,
-		Net:       "tcp",
-		Addr:      cfg.GetHostname(),
-		DBName:    cfg.Database,
-		ParseTime: true,
-		Params:    cfg.Options,
+		User:                 username,
+		Passwd:               password,
+		Net:                  "tcp",
+		Addr:                 cfg.GetHostname(),
+		DBName:               cfg.Database,
+		ParseTime:            true,
+		AllowNativePasswords: true,
+		Params:               cfg.Options,
 	}
 	dsn := mysqlCfg.FormatDSN()
 

util/sqldb/sqldb_test.go

@@ -0,0 +1,84 @@
+package sqldb
+
+import (
+	"context"
+	"runtime"
+	"strconv"
+	"testing"
+	"time"
+
+	"github.com/stretchr/testify/require"
+	testcontainers "github.com/testcontainers/testcontainers-go"
+	testmysql "github.com/testcontainers/testcontainers-go/modules/mysql"
+	"github.com/testcontainers/testcontainers-go/wait"
+
+	"github.com/argoproj/argo-workflows/v4/config"
+	"github.com/argoproj/argo-workflows/v4/util/logging"
+)
+
+type mysqlVariant struct {
+	image       string
+	waitMessage string
+}
+
+var mysqlVariants = map[string]mysqlVariant{
+	"MySQL":   {image: "mysql:8.4", waitMessage: "port: 3306  MySQL Community Server"},
+	"MariaDB": {image: "mariadb:11.4", waitMessage: "mariadbd: ready for connections"},
+}
+
+func setupMySQLContainer(ctx context.Context, t *testing.T, v mysqlVariant) (config.DBConfig, func()) {
+	t.Helper()
+
+	c, err := testmysql.Run(ctx,
+		v.image,
+		testmysql.WithDatabase("argo"),
+		testmysql.WithUsername("argo"),
+		testmysql.WithPassword("argo"),
+		testcontainers.WithWaitStrategy(
+			wait.ForAll(
+				wait.ForLog(v.waitMessage).WithStartupTimeout(60*time.Second),
+				wait.ForListeningPort("3306/tcp"),
+			)),
+	)
+	require.NoError(t, err)
+
+	host, err := c.Host(ctx)
+	require.NoError(t, err)
+	p, err := c.MappedPort(ctx, "3306/tcp")
+	require.NoError(t, err)
+	port, err := strconv.Atoi(p.Port())
+	require.NoError(t, err)
+
+	return config.DBConfig{
+		MySQL: &config.MySQLConfig{
+			DatabaseConfig: config.DatabaseConfig{
+				Database: "argo",
+				Host:     host,
+				Port:     port,
+			},
+		},
+	}, func() { testcontainers.TerminateContainer(c) } //nolint:errcheck
+}
+
+// TestMySQLSessionConnect verifies that CreateDBSessionWithCreds can connect
+// to both MySQL and MariaDB. MariaDB requires AllowNativePasswords.
+func TestMySQLSessionConnect(t *testing.T) {
+	if runtime.GOOS == "windows" {
+		t.Skip("test requires Linux container")
+	}
+
+	for name, variant := range mysqlVariants {
+		t.Run(name, func(t *testing.T) {
+			ctx := logging.TestContext(t.Context())
+			dbConfig, cleanup := setupMySQLContainer(ctx, t, variant)
+			defer cleanup()
+
+			sess, dbType, err := CreateDBSessionWithCreds(dbConfig, "argo", "argo")
+			require.NoError(t, err)
+			defer sess.Close()
+
+			require.Equal(t, MySQL, dbType)
+			require.NoError(t, sess.Ping())
+		})
+	}
+}