fix: upgrade expr to bring in bugfix. Fixes #15093#15168
Conversation
As @dmarquez-splunk discovered, the Sprig upgrade in argoproj#14307 introduced a regression when evaluating an expression that has a call to a variadic Sprig function with `nil`. This was fixed in expr-lang/expr#868, which was released as [v1.17.7](https://github.com/expr-lang/expr/releases/tag/v1.17.7). I also added a test case to prevent regressions. Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com>
MasonM
changed the title
MasonM
added
type/regression
|
Thank you |
|
❌ Cherry-pick failed for 3.6. Please check the workflow logs for details. |
|
🍒 Cherry-pick PR created for 3.7: #15171 |
Do we need to manually cherry-pik to 3.6? I'd like these changes to be incorporated into the prev version to avoid requiring an upgrade to resolve this issue for us in the short term if possible! |
I've got tooling to help with this - so I've already done it. I use the labels for tracking them, and then discover failed cherry-picks and do them locally. Sometimes I appreciate someone else doing it, so thanks, but I've got this one. |
argoproj#15168 for 3.7) (argoproj#15171) Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com> Co-authored-by: Mason Malone <651224+MasonM@users.noreply.github.com>
argoproj#15168 for 3.6) (argoproj#15182) Signed-off-by: Mason Malone <651224+MasonM@users.noreply.github.com> Signed-off-by: Alan Clucas <alan@clucas.org> Co-authored-by: Mason Malone <651224+MasonM@users.noreply.github.com>
3 participants
Fixes #15093
Motivation
As @dmarquez-splunk discovered, the
exprupgrade in #14307 introduced a regression when evaluating an expression that has a call to a variadic function withnil. This was fixed in expr-lang/expr#868, which was released as v1.17.7.Modifications
Update
exprVerification
Added a test case
Documentation
N/A