fix: populate scope with empty values for outputs of skipped/omitted …#15926
Closed
KowalczykBartek wants to merge 2 commits into
Closed
fix: populate scope with empty values for outputs of skipped/omitted …#15926KowalczykBartek wants to merge 2 commits into
KowalczykBartek wants to merge 2 commits into
Conversation
isubasinghe
force-pushed
the
fix-unresolved-reference-for-child-main-branch
branch
from
1e5905f to
ae5bc69
Compare
…steps Signed-off-by: Bartek Kowalczyk <kowalczyk.bartek.mail@gmail.com> Co-Authored-By: Bartek Kowalczyk <kowalczyk.bartek.mail@gmail.com> Signed-off-by: isubasinghe <isitha@pipekit.io>
isubasinghe
force-pushed
the
fix-unresolved-reference-for-child-main-branch
branch
from
4f29329 to
6208921
Compare
Member
|
@KowalczykBartek your commit isn't signed off. I've addressed the linter issues and squashed my commit onto yours. Hopefully you are okay with this? |
Author
|
@isubasinghe all fine, thank you very much for help, but I cannot understand why my commit is not visible as signed :D I signed it, it also visible here on github as verified by my pgp key EDIT: ok I know - i used -S instead of -s - details matters |
Member
|
@KowalczykBartek can you please open another PR and sign it off? I cannot approve this according the CNCF rules. |
KowalczykBartek
deleted the
fix-unresolved-reference-for-child-main-branch
branch
Author
|
@isubasinghe I believe this one is the last one #15932 (its signed and verified) :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15873
Motivation
Try to resolve child's output when steps is actually skipped.