Skip to content

fix: Remove overly aggressive node deletion on parameter override (fixes #16055) #16056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
syhstanley wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: Remove overly aggressive node deletion on parameter override (fixes #16055) #16056

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d191ce7
fix: delete stale TaskGroup children on retry with parameter override…
stanleyshen2003 Mar 30, 2026
ad73da3
fix: add nil check when accessing workflow nodes in retry logic
stanleyshen2003 Apr 15, 2026
3164ebc
fix: Remove overly aggressive node deletion on parameter override (fi…
stanleyshen2003 Apr 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions workflow/util/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1233,6 +1233,12 @@ func FormulateRetryWorkflow(ctx context.Context, wf *wfv1.Workflow, restartSucce
toDelete = setUnion(toDelete, pathToDelete)
}

// Note: The parameter override deletion logic from PR #15827 has been removed.
// The issue it was trying to fix (workflow stuck in Running) should be addressed
// in the controller's node state management, not by deleting unrelated nodes.
// Deleting all TaskGroup children indiscriminately causes issues #16055 where
// successful sibling nodes are incorrectly removed.

for nodeID := range toReset {
// avoid resetting nodes that are marked for deletion
if in := toDelete[nodeID]; in {
Expand Down
Loading