fix(errors): retry transient "failed calling webhook" apiserver 500s#16259
Open
HsiuChuanHsu wants to merge 2 commits into
Open
fix(errors): retry transient "failed calling webhook" apiserver 500s#16259HsiuChuanHsu wants to merge 2 commits into
HsiuChuanHsu wants to merge 2 commits into
Conversation
Signed-off-by: HsiuChuanHsu <hchsu2106@gmail.com>
Signed-off-by: HsiuChuanHsu <hchsu2106@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14220
Motivation
A webhook can be briefly unreachable during normal operation. While it is unreachable, the kube-apiserver
rejects the request with an HTTP 500
InternalError:An earlier attempt (PR #16038) treated all 500s as transient which was not that correct. Blindly retrying them would mask real failures and pile load onto an already-unhealthy apiserver.
So this task is to retry only this known-transient case while leaving every other 500 classified as permanent.
Modifications
Added a single targeted classifier in
util/errors/errors.go, same style as the existingisResourceQuotaTimeoutErr:And added into isTransientErr` alongside the other transient checks.
Verification
Documentation
AI
Claude Sonnet 4.8