Skip to content

fix(ui): include pod template annotations in pod-scope link objects (#16190)#16266

Open
ArjunPakhan wants to merge 1 commit into
argoproj:mainfrom
ArjunPakhan:ui/fix-pod-link-annotations
Open

fix(ui): include pod template annotations in pod-scope link objects (#16190)#16266
ArjunPakhan wants to merge 1 commit into
argoproj:mainfrom
ArjunPakhan:ui/fix-pod-link-annotations

Conversation

@ArjunPakhan

Copy link
Copy Markdown

Description

Fixes #16190

This PR updates the WorkflowNodeSummary component within workflow-node-info.tsx to include the corresponding template's metadata annotations when constructing pod-scope link context objects.

Summary of Changes

  • File Modified: ui/src/workflows/components/workflow-node-info/workflow-node-info.tsx
  • Logic Added: In the <Links> rendering node for props.node.type === 'Pod', the object.metadata payload now looks up and appends the active template annotations map from the workflow spec by matching against props.node.templateName.
  • Impact: This safely populates the internal context model passed down to processURL inside links.tsx, allowing expressions like ${metadata.annotations['key']} to resolve dynamically on custom platform metrics or logging dashboards without requiring separate API roundtrips.

Checklist

  • My code follows the clean-code style guidelines of this project
  • I have performed a self-review of my own code structural footprint
  • I signed-off my commit using the -s flag to clear DCO certification checks
  • This change requires no secondary backend database or controller runtime updates

Reason for Change

Currently, pod-scope links only receive a truncated object payload carrying { namespace, name }. This architectural gap completely drops template-defined context annotations on custom ML training orchestrations or multi-tenant pipeline platform dashboards, causing variable interpolation expressions to silently resolve to null.

@ArjunPakhan
ArjunPakhan requested a review from a team as a code owner June 13, 2026 19:42
@ArjunPakhan ArjunPakhan changed the title ui: include pod template annotations in pod-scope link objects (#16190) fix(ui): include pod template annotations in pod-scope link objects (#16190) Jun 13, 2026
@ArjunPakhan
ArjunPakhan force-pushed the ui/fix-pod-link-annotations branch 7 times, most recently from 337d6b5 to 1a7a650 Compare June 13, 2026 20:25
@ArjunPakhan
ArjunPakhan force-pushed the ui/fix-pod-link-annotations branch from 1a7a650 to 1dad40a Compare June 13, 2026 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: include pod template annotations in pod-scope link objects

1 participant