fix(ui): include pod template annotations in pod-scope link objects (#16190)#16266
Open
ArjunPakhan wants to merge 1 commit into
Open
fix(ui): include pod template annotations in pod-scope link objects (#16190)#16266ArjunPakhan wants to merge 1 commit into
ArjunPakhan wants to merge 1 commit into
Conversation
ArjunPakhan
force-pushed
the
ui/fix-pod-link-annotations
branch
7 times, most recently
from
June 13, 2026 20:25
337d6b5 to
1a7a650
Compare
argoproj#16190) Signed-off-by: Arjun Pakhan <arjunpakhan@gmail.com>
ArjunPakhan
force-pushed
the
ui/fix-pod-link-annotations
branch
from
June 13, 2026 20:29
1a7a650 to
1dad40a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #16190
This PR updates the
WorkflowNodeSummarycomponent withinworkflow-node-info.tsxto include the corresponding template's metadata annotations when constructing pod-scope link context objects.Summary of Changes
ui/src/workflows/components/workflow-node-info/workflow-node-info.tsx<Links>rendering node forprops.node.type === 'Pod', theobject.metadatapayload now looks up and appends the active template annotations map from the workflow spec by matching againstprops.node.templateName.processURLinsidelinks.tsx, allowing expressions like${metadata.annotations['key']}to resolve dynamically on custom platform metrics or logging dashboards without requiring separate API roundtrips.Checklist
-sflag to clear DCO certification checksReason for Change
Currently, pod-scope links only receive a truncated object payload carrying
{ namespace, name }. This architectural gap completely drops template-defined context annotations on custom ML training orchestrations or multi-tenant pipeline platform dashboards, causing variable interpolation expressions to silently resolve tonull.