Skip to content

Commit 15bb1f8

Browse files
committed
scripts/test_antlr_grammar.sh: also exclude bidirectional isolate test files
The grammar cannot recursively count the LRI/RLI/FSI/PDI isolates added to the validator any more than it can count LRO/RLO/LRE/RLE/PDF, so apply the same skip rule to filenames matching '_isolate_override'.
1 parent 05f2d8f commit 15bb1f8

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

scripts/test_antlr_grammar.sh

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -60,9 +60,9 @@ done < <(
6060
"^\/\/ (Syntax|Type|Declaration)Error|^\/\/ ParserError (1684|2837|3716|3997|5333|6275|6281|6933|7319|8185|7637)|^==== Source:|^pragma experimental solidity;" \
6161
"${ROOT_DIR}/test/libsolidity/syntaxTests" \
6262
"${ROOT_DIR}/test/libsolidity/semanticTests" |
63-
# Skipping the unicode tests as I couldn't adapt the lexical grammar to recursively counting RLO/LRO/PDF's.
64-
grep -v -E 'comments/.*_direction_override.*.sol' |
65-
grep -v -E 'literals/.*_direction_override.*.sol' |
63+
# Skipping the unicode tests as I couldn't adapt the lexical grammar to recursively counting RLO/LRO/PDF's or LRI/RLI/FSI/PDI's.
64+
grep -v -E 'comments/.*_(direction|isolate)_override.*\.sol' |
65+
grep -v -E 'literals/.*_(direction|isolate)_override.*\.sol' |
6666
# Skipping a test with "revert E;" because ANTLR cannot distinguish it from
6767
# a variable declaration.
6868
grep -v -E 'revertStatement/non_called.sol' |

0 commit comments

Comments
 (0)