More const

Author: msooseth

libevmasm/ConstantOptimiser.cpp

@@ -45,7 +45,7 @@ unsigned ConstantOptimisationMethod::optimiseConstants(
 			if (item.type() == Push)
 				pushes[item]++;
 		std::map<u256, AssemblyItems> pendingReplacements;
-		for (auto it: pushes)
+		for (const auto& it: pushes)
 		{
 			AssemblyItem const& item = it.first;
 			if (item.data() < 0x100)

libevmasm/ControlFlowGraph.cpp

@@ -292,7 +292,7 @@ void ControlFlowGraph::gatherKnowledge()
 				}
 			}
 			else
-				for (auto tag: tags)
+				for (const auto& tag: tags)
 					addWorkQueueItem(item, BlockId(tag), state);
 		}
 		else if (block.begin <= pc && pc < block.end)
@@ -327,7 +327,7 @@ BasicBlocks ControlFlowGraph::rebuildCode()
 				pushes[ref]++;
 
 	std::set<BlockId> blocksToAdd;
-	for (auto it: m_blocks)
+	for (const auto& it: m_blocks)
 		blocksToAdd.insert(it.first);
 	std::set<BlockId> blocksAdded;
 	BasicBlocks blocks;

libevmasm/ExpressionClasses.cpp

@@ -159,7 +159,7 @@ bool ExpressionClasses::knownToBeDifferentBy32(ExpressionClasses::Id _a, Express
 	return v && *v + 31 > u256(62);
 }
 
-bool ExpressionClasses::knownZero(Id _c)
+bool ExpressionClasses::knownZero(Id _c) const
 {
 	return Pattern(u256(0)).matches(representative(_c), *this);
 }
@@ -169,7 +169,7 @@ bool ExpressionClasses::knownNonZero(Id _c)
 	return Pattern(u256(0)).matches(representative(find(Instruction::ISZERO, {_c})), *this);
 }
 
-u256 const* ExpressionClasses::knownConstant(Id _c)
+u256 const* ExpressionClasses::knownConstant(Id _c) const
 {
 	std::map<unsigned, Expression const*> matchGroups;
 	Pattern constant(Push);

libevmasm/ExpressionClasses.h

@@ -101,13 +101,13 @@ class ExpressionClasses
 	bool knownToBeDifferentBy32(Id _a, Id _b);
 	/// @returns true if the value of the given class is known to be zero.
 	/// @note that this is not the negation of knownNonZero
-	bool knownZero(Id _c);
+	bool knownZero(Id _c) const;
 	/// @returns true if the value of the given class is known to be nonzero.
 	/// @note that this is not the negation of knownZero
 	bool knownNonZero(Id _c);
 	/// @returns a pointer to the value if the given class is known to be a constant,
 	/// and a nullptr otherwise.
-	u256 const* knownConstant(Id _c);
+	u256 const* knownConstant(Id _c) const;
 
 	/// Stores a copy of the given AssemblyItem and returns a pointer to the copy that is valid for
 	/// the lifetime of the ExpressionClasses object.

liblangutil/CharStream.h

@@ -116,7 +116,7 @@ class CharStream
 
 	/// Tests whether or not given octet sequence is present at the current position in stream.
 	/// @returns true if the sequence could be found, false otherwise.
-	bool prefixMatch(std::string_view _sequence)
+	bool prefixMatch(std::string_view _sequence) const
 	{
 		if (isPastEndOfInput(_sequence.size()))
 			return false;

libsolidity/analysis/ControlFlowBuilder.cpp

@@ -427,7 +427,7 @@ bool ControlFlowBuilder::visit(Return const& _return)
 	{
 		appendControlFlow(*_return.expression());
 		// Returns with return expression are considered to be assignments to the return parameters.
-		for (auto returnParameter: _return.annotation().functionReturnParameters->parameters())
+		for (const auto& returnParameter: _return.annotation().functionReturnParameters->parameters())
 			m_currentNode->variableOccurrences.emplace_back(
 				*returnParameter,
 				VariableOccurrence::Kind::Assignment,

libsolidity/analysis/DeclarationContainer.cpp

@@ -204,7 +204,7 @@ void DeclarationContainer::populateHomonyms(std::back_insert_iterator<Homonyms>
 	for (DeclarationContainer const* innerContainer: m_innerContainers)
 		innerContainer->populateHomonyms(_it);
 
-	for (auto [name, location]: m_homonymCandidates)
+	for (const auto& [name, location]: m_homonymCandidates)
 	{
 		ResolvingSettings settings;
 		settings.recursive = true;

libsolidity/analysis/NameAndTypeResolver.cpp

@@ -250,7 +250,7 @@ void NameAndTypeResolver::warnHomonymDeclarations() const
 	DeclarationContainer::Homonyms homonyms;
 	m_scopes.at(nullptr)->populateHomonyms(back_inserter(homonyms));
 
-	for (auto [innerLocation, outerDeclarations]: homonyms)
+	for (const auto& [innerLocation, outerDeclarations]: homonyms)
 	{
 		solAssert(innerLocation && !outerDeclarations.empty(), "");
 

libsolidity/analysis/SyntaxChecker.cpp

@@ -358,7 +358,7 @@ bool SyntaxChecker::visit(UnaryOperation const& _operation)
 bool SyntaxChecker::visit(InlineAssembly const& _inlineAssembly)
 {
 	if (_inlineAssembly.flags())
-		for (auto flag: *_inlineAssembly.flags())
+		for (const auto& flag: *_inlineAssembly.flags())
 		{
 			if (*flag == "memory-safe")
 			{

libsolidity/ast/ASTJsonExporter.cpp

@@ -334,7 +334,7 @@ bool ASTJsonExporter::visit(IdentifierPath const& _node)
 {
 	Json nameLocations = Json::array();
 
-	for (SourceLocation const location: _node.pathLocations())
+	for (SourceLocation const& location: _node.pathLocations())
 		nameLocations.emplace_back(sourceLocationToString(location));
 
 	setJsonNode(_node, "IdentifierPath", {