Address review comments. Add cmdLineTest

rodiazet · rodiazet · commit e63d28b553c0 · 2026-03-24T12:23:23.000+01:00
diff --git a/test/cmdlineTests/yul_optimizer_unused_store_eliminator_without_ssa_transform/args b/test/cmdlineTests/yul_optimizer_unused_store_eliminator_without_ssa_transform/args
@@ -0,0 +1 @@
+--strict-assembly --optimize --yul-optimizations S: --ir-optimized
diff --git a/test/cmdlineTests/yul_optimizer_unused_store_eliminator_without_ssa_transform/input.yul b/test/cmdlineTests/yul_optimizer_unused_store_eliminator_without_ssa_transform/input.yul
@@ -0,0 +1,11 @@
+object "UnusedStoreEliminatorNoSSA" {
+	code {
+		let x := calldataload(4)
+		let a := add(x, 32)
+		x := add(x, 32)
+		let b := x
+		let outLen := 32
+		mstore(a, 0xAA)
+		return(b, outLen)
+	}
+}
diff --git a/test/cmdlineTests/yul_optimizer_unused_store_eliminator_without_ssa_transform/output b/test/cmdlineTests/yul_optimizer_unused_store_eliminator_without_ssa_transform/output
@@ -0,0 +1,17 @@
+
+======= input.yul (EVM) =======
+
+Pretty printed source:
+object "UnusedStoreEliminatorNoSSA" {
+    code {
+        {
+            let x := calldataload(4)
+            let a := add(x, 32)
+            x := add(x, 32)
+            let b := x
+            let outLen := 32
+            mstore(a, 0xAA)
+            return(b, outLen)
+        }
+    }
+}
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/dependency_reassigned_prevents_elimination.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/dependency_reassigned_prevents_elimination.yul
@@ -11,13 +11,11 @@
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     {
-//         let x := calldataload(0)
-//         x := calldataload(32)
-//         let a := add(x, 32)
-//         let b := x
-//         let outLen := 32
-//         mstore(a, 0xAA)
-//         return(b, outLen)
-//     }
+//     let x := calldataload(0)
+//     x := calldataload(32)
+//     let a := add(x, 32)
+//     let b := x
+//     let outLen := 32
+//     mstore(a, 0xAA)
+//     return(b, outLen)
 // }
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/function_parameter_as_mstore_location_covering.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/function_parameter_as_mstore_location_covering.yul
@@ -13,7 +13,6 @@
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     { }
 //     function f(arg)
 //     {
 //         let a := add(arg, 1)
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/function_parameter_as_mstore_location_unrelated.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/function_parameter_as_mstore_location_unrelated.yul
@@ -13,13 +13,11 @@
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     { }
 //     function f(arg)
 //     {
 //         let a := add(arg, 32)
 //         let b := arg
 //         let outLen := 32
-//         let _2 := 0xAA
 //         return(b, outLen)
 //     }
 // }
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/function_parameter_reassigned_as_mstore_location_covering.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/function_parameter_reassigned_as_mstore_location_covering.yul
@@ -13,7 +13,6 @@
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     { }
 //     function f(arg)
 //     {
 //         let b := arg
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/function_parameter_reassigned_as_mstore_location_unrelated.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/function_parameter_reassigned_as_mstore_location_unrelated.yul
@@ -13,7 +13,6 @@
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     { }
 //     function f(arg)
 //     {
 //         let b := arg
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/mstore_location_reassigned.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/mstore_location_reassigned.yul
@@ -13,14 +13,12 @@
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     {
-//         let x := calldataload(4)
-//         let x_5 := x
-//         let a := add(x_5, 32)
-//         x := add(x_5, 32)
-//         let b := x
-//         let outLen := 32
-//         mstore(a, 0xAA)
-//         return(b, outLen)
-//     }
+//     let x := calldataload(4)
+//     let x_5 := x
+//     let a := add(x_5, 32)
+//     x := add(x_5, 32)
+//     let b := x
+//     let outLen := 32
+//     mstore(a, 0xAA)
+//     return(b, outLen)
 // }
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/multi_return_var_not_tracked.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/multi_return_var_not_tracked.yul
@@ -13,15 +13,13 @@
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     {
-//         let a, b := g()
-//         let c := add(a, 32)
-//         mstore(c, 0xAA)
-//         return(a, b)
-//     }
 //     function g() -> r1, r2
 //     {
 //         r1 := calldataload(0)
 //         r2 := calldataload(32)
 //     }
+//     let a, b := g()
+//     let c := add(a, 32)
+//     mstore(c, 0xAA)
+//     return(a, b)
 // }
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/override_store_function_parameter_location_elimination.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/override_store_function_parameter_location_elimination.yul
@@ -18,12 +18,15 @@
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     { }
 //     function direct(arg, value)
-//     { sstore(arg, add(value, 1)) }
+//     {
+//         let v1 := add(value, 1)
+//         sstore(arg, v1)
+//     }
 //     function indirect(arg_1, value_2)
 //     {
 //         let loc := arg_1
-//         sstore(loc, add(value_2, 1))
+//         let value1 := add(value_2, 1)
+//         sstore(loc, value1)
 //     }
 // }
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/ssa_dependency_chain_allows_elimination.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/ssa_dependency_chain_allows_elimination.yul
@@ -11,13 +11,10 @@
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     {
-//         let x := calldataload(0)
-//         let y := add(x, 32)
-//         let a := add(y, 32)
-//         let b := x
-//         let outLen := 32
-//         let _4 := 0xAA
-//         return(b, outLen)
-//     }
+//     let x := calldataload(0)
+//     let y := add(x, 32)
+//     let a := add(y, 32)
+//     let b := x
+//     let outLen := 32
+//     return(b, outLen)
 // }
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/sstore_dependency_as_function_reassigned_argument.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/sstore_dependency_as_function_reassigned_argument.yul
@@ -11,7 +11,6 @@
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     { }
 //     function f(arg)
 //     {
 //         let x := arg
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/sstore_function_parameter_location_loaded_no_elimination.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/sstore_function_parameter_location_loaded_no_elimination.yul
@@ -38,30 +38,34 @@
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     { }
 //     function direct(arg, value)
 //     {
 //         sstore(arg, value)
 //         pop(sload(arg))
-//         sstore(arg, add(value, 1))
+//         let value1 := add(value, 1)
+//         sstore(arg, value1)
 //     }
 //     function indirect(arg_1, value_2)
 //     {
 //         let loc := arg_1
 //         sstore(loc, value_2)
 //         pop(sload(arg_1))
-//         sstore(loc, add(value_2, 1))
+//         let value1_3 := add(value_2, 1)
+//         sstore(loc, value1_3)
 //     }
 //     function mix_elimination(arg_4, value_5)
 //     {
-//         pop(sload(add(arg_4, 1)))
-//         sstore(arg_4, add(value_5, 1))
+//         let loc_6 := add(arg_4, 1)
+//         pop(sload(loc_6))
+//         let value1_7 := add(value_5, 1)
+//         sstore(arg_4, value1_7)
 //     }
 //     function mix_no_elimination(arg_8, value_9)
 //     {
 //         let loc_10 := arg_8
 //         sstore(arg_8, value_9)
 //         pop(sload(loc_10))
-//         sstore(arg_8, add(value_9, 1))
+//         let value1_11 := add(value_9, 1)
+//         sstore(arg_8, value1_11)
 //     }
 // }
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/sstore_location_reassigned.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/sstore_location_reassigned.yul
@@ -17,14 +17,12 @@ object "test" {
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     {
-//         let x := calldataload(4)
-//         mstore(32, 0xAA)
-//         let a := add(x, 32)
-//         x := add(x, 32)
-//         let b := x
-//         sstore(a, 32)
-//         let ret := sload(b)
-//         revert(ret, 32)
-//     }
+//     let x := calldataload(4)
+//     mstore(32, 0xAA)
+//     let a := add(x, 32)
+//     x := add(x, 32)
+//     let b := x
+//     sstore(a, 32)
+//     let ret := sload(b)
+//     revert(ret, 32)
 // }
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/store_assigned_function_parameter_location_no_elimination.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/store_assigned_function_parameter_location_no_elimination.yul
@@ -30,23 +30,26 @@
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     { }
 //     function direct(arg, value)
 //     {
 //         sstore(arg, value)
 //         arg := add(arg, 1)
-//         sstore(arg, add(value, 1))
+//         let value1 := add(value, 1)
+//         sstore(arg, value1)
 //     }
 //     function indirect(arg_1, value_2)
 //     {
 //         let loc := arg_1
 //         sstore(loc, value_2)
 //         loc := add(loc, 1)
-//         sstore(loc, add(value_2, 1))
+//         let value1_3 := add(value_2, 1)
+//         sstore(loc, value1_3)
 //     }
 //     function mix(arg_4, value_5)
 //     {
-//         sstore(arg_4, value_5)
-//         sstore(arg_4, add(value_5, 1))
+//         let loc_6 := arg_4
+//         sstore(loc_6, value_5)
+//         let value1_7 := add(value_5, 1)
+//         sstore(arg_4, value1_7)
 //     }
 // }
diff --git a/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/transitive_dependency_reassigned_prevents_elimination.yul b/test/libyul/yulOptimizerTests/unusedStoreEliminatorNoSsaTransform/transitive_dependency_reassigned_prevents_elimination.yul
@@ -12,14 +12,12 @@
 // step: unusedStoreEliminatorNoSsaTransform
 //
 // {
-//     {
-//         let x := calldataload(0)
-//         let y := add(x, 32)
-//         x := calldataload(32)
-//         let a := y
-//         let b := x
-//         let outLen := 32
-//         mstore(a, 0xAA)
-//         return(b, outLen)
-//     }
+//     let x := calldataload(0)
+//     let y := add(x, 32)
+//     x := calldataload(32)
+//     let a := y
+//     let b := x
+//     let outLen := 32
+//     mstore(a, 0xAA)
+//     return(b, outLen)
 // }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+--strict-assembly --optimize --yul-optimizations S: --ir-optimized`