Remove EOF: Remove support for EOF related flag from solc executable.#16760
Conversation
matheusaaguiar
left a comment
matheusaaguiar
left a comment
There was a problem hiding this comment.
Looks good to me.
I was going to suggest to also remove the option from the Json Input/Output interface, but I saw that's done in the follow-up PR.
There was a problem hiding this comment.
We could add a changelog entry saying that EOF support has been removed. It's still technically in the codebase, but once you disallow enabling it, it's all essentially dead code.
There was a problem hiding this comment.
Ok. So I will move change log entry from the last PR to this one.
There was a problem hiding this comment.
I pushed additional commit but GH is dead today.
nikola-matic
left a comment
nikola-matic
left a comment
There was a problem hiding this comment.
Shouldn't you be removing the standard JSON input options for EOF here as well?
It’s removed in the following PR removing EOF from |
Leave the |
rodiazet
force-pushed
the
remove-eof-solc
branch
3 times, most recently
from
3f64c28 to
59739a4
Compare
Done |
| // EVM Object Format version to compile for (optional, experimental). | ||
| // Currently the only valid value is 1. If not specified, legacy non-EOF bytecode will be generated. | ||
| // Requires `evmVersion` >= osaka. | ||
| "eofVersion": null, |
There was a problem hiding this comment.
Bring this back pls and move to the libsolidity PR
There was a problem hiding this comment.
Nooo Radek, you should have left in the removal of --experimental-eof-version in the Experimental section - I just wanted you to leave the eofVersion in the docs.
There was a problem hiding this comment.
That is what I did or I misunderstood your previous comment. :)
There was a problem hiding this comment.
Remove the EOF entry in the experimental section is what I meant; you had it before, but then got rid of it. It mentioned --experimental-eof-version explicitly, which you're removing in this PR, so the docs referring to it should be removed as well.
There was a problem hiding this comment.
OK. I haven’t noticed it’s not the only one change there.
4 participants
This PR removes
--experimental-eof-versionflag from solc and cmd line tests which test it.