Add new migrations format#2250
Merged
Merged
Conversation
363f88a to
44fac49
Compare
44fac49 to
e7f6696
Compare
marcocastignoli
requested changes
Jul 29, 2025
marcocastignoli
left a comment
Member
There was a problem hiding this comment.
A couple questions while I continue reviewing
marcocastignoli
requested changes
Jul 29, 2025
marcocastignoli
left a comment
Member
There was a problem hiding this comment.
Seems like ln -r is not supported on mac
> rm -rf migrations-temp && mkdir -p migrations-temp && ln -srf ./database-specs/migrations/* ./migrations-temp/ && ln -srf ./migrations/* ./migrations-temp/
ln: illegal option -- r
usage: ln [-s [-F] | -L | -P] [-f | -i] [-hnv] source_file [target_file]
ln [-s [-F] | -L | -P] [-f | -i] [-hnv] source_file ... target_dir
link source_file target_file
npm error Lifecycle script `migrate:setup` failed with error:
Member
Author
Oh no, that's an issue... |
Member
Author
added the fix |
marcocastignoli
approved these changes
Jul 29, 2025
marcocastignoli
left a comment
Member
There was a problem hiding this comment.
LGTM! Great, I like how migrations are structured now! :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #2123 and verifier-alliance/database-specs#31
Changes: