Skip to content

Add new migrations format#2250

Merged
manuelwedler merged 14 commits into
stagingfrom
add-new-migrations-format
Jul 29, 2025
Merged

Add new migrations format#2250
manuelwedler merged 14 commits into
stagingfrom
add-new-migrations-format

Conversation

@manuelwedler

@manuelwedler manuelwedler commented Jul 23, 2025

Copy link
Copy Markdown
Member

See #2123 and verifier-alliance/database-specs#31

Changes:

  • Adds dbmate as the migration tool as we also will have it in VerA
  • Adds npm scripts to run dbmate to set it up depending on the command (we need to merge the two migration folders of sourcify and vera)
  • Adds documentation about how to make new schema changes
  • Removes db-migrate
  • Adds a CI workflow to validate that the migrations work as expected

@manuelwedler manuelwedler force-pushed the add-new-migrations-format branch 7 times, most recently from 363f88a to 44fac49 Compare July 28, 2025 07:32
@manuelwedler manuelwedler force-pushed the add-new-migrations-format branch from 44fac49 to e7f6696 Compare July 28, 2025 07:44
@manuelwedler manuelwedler marked this pull request as ready for review July 28, 2025 07:59

@marcocastignoli marcocastignoli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions while I continue reviewing

Comment thread .circleci/new_branch.yml
Comment thread .circleci/config.yml

@marcocastignoli marcocastignoli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like ln -r is not supported on mac

> rm -rf migrations-temp && mkdir -p migrations-temp && ln -srf ./database-specs/migrations/* ./migrations-temp/ && ln -srf ./migrations/* ./migrations-temp/

ln: illegal option -- r
usage: ln [-s [-F] | -L | -P] [-f | -i] [-hnv] source_file [target_file]
       ln [-s [-F] | -L | -P] [-f | -i] [-hnv] source_file ... target_dir
       link source_file target_file
npm error Lifecycle script `migrate:setup` failed with error:

@manuelwedler

Copy link
Copy Markdown
Member Author

Seems like ln -r is not supported on mac

Oh no, that's an issue...

@manuelwedler

Copy link
Copy Markdown
Member Author

Seems like ln -r is not supported on mac

added the fix

@marcocastignoli marcocastignoli left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great, I like how migrations are structured now! :)

@manuelwedler manuelwedler merged commit 65a9add into staging Jul 29, 2025
7 checks passed
@github-project-automation github-project-automation Bot moved this from Sprint - Needs Review to Sprint - Done in Sourcify Public [Archived] Jul 29, 2025
@manuelwedler manuelwedler deleted the add-new-migrations-format branch July 29, 2025 11:05
@marcocastignoli marcocastignoli moved this from Sprint - Done to COMPLETED in Sourcify Public [Archived] Jul 31, 2025
@stackenbotten3000 stackenbotten3000 moved this to COMPLETED in Sourcify Public Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: COMPLETED

Development

Successfully merging this pull request may close these issues.

4 participants