Commit 52ff277
committed
feat(wallets): compose signers from IPrivateKeyProviders
Closes #112.
Pushes signer composition down one layer: an IArkadeWalletSigner is now
always a CompositeArkadeWalletSigner built from one or more
IPrivateKeyProviders. Each provider answers CanProvideAsync(descriptor) and
exposes the signing operations rooted in the key it owns; the composite
dispatches each call to the first provider that claims the descriptor.
The three previous concrete signers collapse into providers behind the same
composite:
- Bip39KeyProvider (was HierarchicalDeterministicWalletSigner)
claim by master fingerprint match on the descriptor's origin.
- NsecKeyProvider (was NSecWalletSigner)
claim by x-only pubkey match on tr() descriptors.
- RemoteTransportKeyProvider (was RemoteArkadeWalletSigner)
claim by IRemoteSignerTransport.KnowsWalletAsync; passthrough proxy.
DefaultWalletProvider builds the composition automatically — adds the
matching local provider if Wallet.Secret is set, then a remote provider if
an IRemoteSignerTransport claims the wallet. Order is significant: local
providers get first refusal, remote is fallback. This is what makes hybrid
setups (e.g. local view-key paths + HWI spend path) expressible at all —
the previous binary local/remote split foreclosed them.
The interface keeps IArkadeWalletSigner unchanged for SDK consumers (the
TreeSignerSession path is unaffected); the new abstraction is added one
layer below. The three old concrete signer classes are deleted since
they're equivalent to constructing a CompositeArkadeWalletSigner with the
matching single provider — NsecKeyProvider.FromNsec is the new entry
point that mirrors the old NSecWalletSigner.FromNsec static.
The IPrivateKeyProvider shape is operation-level (Sign/SignMusig/
GenerateNonces) rather than returning a raw ECPrivKey, so a remote
provider can implement it honestly without round-tripping secret material
over the wire — the original sketch in #112 had IPrivateKeyProvider return
ECPrivKey, which would have defeated the point of remote signing.
Each local provider keeps its own per-session ConcurrentDictionary
nonce store with the same sessionId-keyed semantics established in #111.1 parent 095ad33 commit 52ff277
12 files changed
Lines changed: 466 additions & 316 deletions
File tree
- NArk.Abstractions/Wallets
- NArk.Core/Wallet
- PrivateKeyProviders
- NArk.Tests
- docs/articles
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
| 8 | + | |
8 | 9 | | |
9 | 10 | | |
10 | 11 | | |
| |||
30 | 31 | | |
31 | 32 | | |
32 | 33 | | |
33 | | - | |
34 | | - | |
35 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
36 | 37 | | |
37 | 38 | | |
38 | 39 | | |
| |||
46 | 47 | | |
47 | 48 | | |
48 | 49 | | |
49 | | - | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
50 | 53 | | |
51 | 54 | | |
52 | | - | |
53 | | - | |
| 55 | + | |
54 | 56 | | |
55 | | - | |
56 | | - | |
| 57 | + | |
| 58 | + | |
57 | 59 | | |
58 | 60 | | |
59 | 61 | | |
60 | 62 | | |
61 | | - | |
62 | | - | |
63 | | - | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
64 | 66 | | |
65 | 67 | | |
66 | 68 | | |
67 | | - | |
68 | | - | |
| 69 | + | |
69 | 70 | | |
70 | 71 | | |
71 | | - | |
72 | | - | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
73 | 78 | | |
74 | 79 | | |
75 | 80 | | |
| |||
Lines changed: 0 additions & 76 deletions
This file was deleted.
0 commit comments