chore(e2e): regtest update#154
Open
d4rp4t wants to merge 11 commits into
Open
Conversation
d4rp4t
force-pushed
the
chore/regtest-update
branch
3 times, most recently
from
22712cb to
7f5160c
Compare
…oved to block based config
d4rp4t
force-pushed
the
chore/regtest-update
branch
from
7f5160c to
ec89614
Compare
arkd's GetVtxoChainAsync returns the virtual-tx chain leaf-first (the VTXO's own tx first, walking back to the Commitment anchor) — the opposite of what UnilateralExitService and ExitWatchtowerService assumed (branch[0] == root, branch[^1] == leaf). This left CSV maturity checks and claim-tx building looking at the Commitment row instead of the leaf, and the broadcast loop submitting the leaf before its own unbroadcast ancestors. - NBXplorerBlockchain.GetTxStatusAsync: Bitcoin Core's getrawtransaction has no "blockheight" field; resolve it via getblockheader on the returned blockhash instead, so confirmed txs no longer report a permanently-null height. - UnilateralExitService: identify leaf tx by txid match against the VTXO's own outpoint, root by ChainedTxType.Commitment, instead of array position; broadcast root→leaf (reverse of storage order) so each tx's parent is already on-chain/in-mempool before it's submitted. - ExitWatchtowerService: same root/leaf identification fix. - Correct doc comments on VtxoBranch, IClientTransport.GetVtxoChainAsync, VtxoChainEntry, and VirtualTxService that documented the wrong order.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.