Skip to content

Commit cd55d66

Browse files
committed
fix: rename imx8m bare uboot hook so binman pkg_resources patch can run
`imx8m.conf` defined a bare `pre_config_uboot_target()`. The framework treats a bare hook as the full implementation and drops any `pre_config_uboot_target__<purpose>` companions, so #9407's auto-enabled `uboot-binman-fix-pkg-resources` extension was never firing on i.MX 8M boards — `tools/binman/control.py`'s `import pkg_resources` stayed unpatched, and `make flash.bin` died with `ModuleNotFoundError` on Python 3.12 / setuptools >= 82. Rename to `pre_config_uboot_target__imx8m_firmware()`. Body unchanged. Both hooks now register and run; order between them doesn't matter (NXP firmware fetch vs. Python source rewrite are independent). Repro: armbian/os run 25262303737, job uboot-mba8mpxl-ras314-current.
1 parent f13bc6b commit cd55d66

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

config/sources/families/imx8m.conf

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,11 @@ case $BOARD in
2828
;;
2929
esac
3030

31-
# bootloader releated
32-
pre_config_uboot_target() {
31+
# bootloader related.
32+
# Use `<hook>__<purpose>` so the framework registers this alongside
33+
# other extensions' hooks at the same stage; a bare
34+
# `pre_config_uboot_target()` would suppress every other registration.
35+
pre_config_uboot_target__imx8m_firmware() {
3336
# get the firmware
3437
rm -rf ${IMX_FIRMWARE}*
3538
curl -fL "https://www.nxp.com/lgfiles/NMG/MAD/YOCTO/${IMX_FIRMWARE}.bin" -o "${IMX_FIRMWARE}.bin" || {

0 commit comments

Comments
 (0)