Update for Radxa Cubie A5E#9626
Merged
Merged
Conversation
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
📝 WalkthroughWalkthroughAdds Radxa Cubie A5E board config tweaks and kernel backports for A523/A5E: enables SDIO WiFi and UART1/Bluetooth, adds SPI controller support and an r‑spi clock, removes an A523 pinctrl IRQ quirk, corrects GPIO interrupt mapping, and updates patch series and family build mapping. ChangesRadxa Cubie A5E / Allwinner A523 backports and build config
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
05
EvilOlaf
reviewed
Apr 2, 2026
EvilOlaf
reviewed
Apr 2, 2026
Member
|
nice |
Member
|
Does this build for you? [🔨] arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dts:15.10-21.4: ERROR (path_references): /aliases: Reference to non-existent node or label "wifi"
[🔨]
[🔨] ERROR: Input tree has errors, aborting (use -f to force output)
[🔨] make[3]: *** [scripts/Makefile.dtbs:153: arch/arm64/boot/dts/allwinner/sun55i-a527-cubie-a5e.dtb] Error 2
[🔨] DTC arch/arm64/boot/dts/allwinner/overlay/sun50i-h616-bananapi-m4-spi1-cs1-spidev.dtbo
[🔨] make[3]: *** Waiting for unfinished jobs.... |
github-actions
Bot
added
size/large
Collaborator
Author
Sorry, I forgot to sync the latest changes |
Collaborator
Author
|
@EvilOlaf can you test? 6.18 works for me. |
juanesf
requested review from
AGM1968,
JohnTheCoolingFan,
PanderMusubi,
TheSnowfield,
Tonymac32,
chraac,
igorpecovnik,
janprunk,
krachlatte,
pyavitz,
schwar3kat,
sgjava and
teknoid
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (2)
config/boards/radxa-cubie-a5e.csc (1)
1-6: ⚡ Quick winAdd maintainer and kernel test target metadata.
BOARD_MAINTAINERis empty andKERNEL_TEST_TARGETis missing; both are recommended by board-config validation and help avoid orphaning while improving CI branch coverage.Proposed patch
BOARD_MAINTAINER="" +KERNEL_TEST_TARGET="current,edge"🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@config/boards/radxa-cubie-a5e.csc` around lines 1 - 6, BOARD_MAINTAINER is empty and KERNEL_TEST_TARGET is missing; update the board config by setting BOARD_MAINTAINER to a non-empty identifier (maintainer name and contact or GitHub handle/email) and add a KERNEL_TEST_TARGET entry with the appropriate CI kernel target token used in this repo (match the format used in other board configs, e.g. the mainline/arm64 test target string) so validation and CI coverage succeed.patch/kernel/archive/sunxi-6.18/patches.backports/22-Enable-wifi-on-Radxa-Cubie-A5E.patch (1)
68-73: ⚡ Quick winAdd
compatibleproperty to wifi@1 node for consistency with device-tree binding standards.The
wifi@1SDIO child node lacks acompatibleproperty. While the aic8800 driver matches devices via SDIO vendor/device IDs rather than compatible strings, adding an explicit compatible property (e.g.,compatible = "aic,aic8800-wifi";) aligns with modern device-tree conventions and improves device identification. This follows the standard practice used by other SDIO WiFi drivers (e.g., Broadcom, TI, Silabs) and future-proofs the binding should driver matching logic change.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@patch/kernel/archive/sunxi-6.18/patches.backports/22-Enable-wifi-on-Radxa-Cubie-A5E.patch` around lines 68 - 73, The wifi@1 SDIO child node is missing a compatible property; add a compatible = "aic,aic8800-wifi"; line inside the wifi@1 node (alongside reg, interrupt-parent, interrupts, interrupt-names) so the node conforms to device-tree binding conventions and can be identified by name in addition to SDIO IDs; update the wifi@1 node in the patch to include this compatible property.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@patch/kernel/archive/sunxi-6.18/patches.backports/21-Enable-uart1-on-Radxa-Cubie-A5E.patch`:
- Line 37: The device-tree fragment has inconsistent spacing in the assignment
to the status property: change the line setting status= "okay"; to use spaces
around the '=' operator (i.e., status = "okay";) so it conforms to DT coding
style; locate the assignment to the status property in the patch (the line
containing status and the string "okay") and adjust spacing only.
In
`@patch/kernel/archive/sunxi-6.18/patches.backports/22-Enable-wifi-on-Radxa-Cubie-A5E.patch`:
- Around line 59-74: The &mmc1 device node is missing the non-removable property
causing the MMC subsystem to treat the soldered SDIO WiFi as a removable card;
update the &mmc1 node (the block that defines vmmc-supply, vqmmc-supply,
mmc-pwrseq, bus-width, pinctrl-0/mmc1_pins, status and the child wifi@1) to add
the non-removable property so the kernel treats the SDIO WiFi as built-in and
disables card-detection polling.
---
Nitpick comments:
In `@config/boards/radxa-cubie-a5e.csc`:
- Around line 1-6: BOARD_MAINTAINER is empty and KERNEL_TEST_TARGET is missing;
update the board config by setting BOARD_MAINTAINER to a non-empty identifier
(maintainer name and contact or GitHub handle/email) and add a
KERNEL_TEST_TARGET entry with the appropriate CI kernel target token used in
this repo (match the format used in other board configs, e.g. the mainline/arm64
test target string) so validation and CI coverage succeed.
In
`@patch/kernel/archive/sunxi-6.18/patches.backports/22-Enable-wifi-on-Radxa-Cubie-A5E.patch`:
- Around line 68-73: The wifi@1 SDIO child node is missing a compatible
property; add a compatible = "aic,aic8800-wifi"; line inside the wifi@1 node
(alongside reg, interrupt-parent, interrupts, interrupt-names) so the node
conforms to device-tree binding conventions and can be identified by name in
addition to SDIO IDs; update the wifi@1 node in the patch to include this
compatible property.
🪄 Autofix (Beta)
❌ Autofix failed (check again to retry)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: c2262fd9-f12a-4be7-bf9d-8aceb930fc62
📒 Files selected for processing (15)
config/boards/radxa-cubie-a5e.cscconfig/sources/families/sun55iw3.confpatch/kernel/archive/sunxi-6.18/patches.backports/20-Add-wifi-to-Radxa-Cubie-A5E.patchpatch/kernel/archive/sunxi-6.18/patches.backports/21-Enable-uart1-on-Radxa-Cubie-A5E.patchpatch/kernel/archive/sunxi-6.18/patches.backports/22-Enable-wifi-on-Radxa-Cubie-A5E.patchpatch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patchpatch/kernel/archive/sunxi-6.18/patches.backports/31-clk_sunxi-ng_sun55i-a523-r_Add_missing_r-spi_module_clock.patchpatch/kernel/archive/sunxi-6.18/patches.backports/32-pinctrl-sunxi-a523-Remove_unneeded_IRQ_remuxing_flag.patchpatch/kernel/archive/sunxi-6.18/patches.backports/33-arm64-dts-allwinner-a523-Add_missing_GPIO_interrupt.patchpatch/kernel/archive/sunxi-6.18/patches.backports/34-fix-wifi-regulator-cubie-a5e.patchpatch/kernel/archive/sunxi-6.18/series.confpatch/kernel/archive/sunxi-7.0/patches.backports/21-Enable-uart1-on-Radxa-Cubie-A5E.patchpatch/kernel/archive/sunxi-7.0/patches.backports/22-Enable-wifi-on-Radxa-Cubie-A5E.patchpatch/kernel/archive/sunxi-7.0/patches.backports/23-fix-wifi-regulator-cubie-a5e.patchpatch/kernel/archive/sunxi-7.0/series.conf
💤 Files with no reviewable changes (1)
- patch/kernel/archive/sunxi-6.18/patches.backports/20-Add-wifi-to-Radxa-Cubie-A5E.patch
Collaborator
Author
|
last build log: https://paste.armbian.eu/uvazoxuqoj |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refines Radxa Cubie A5E support in the Armbian build system. It refreshes the Bluetooth (UART1) DTS patch, replaces the old Wi‑Fi DTS patch with a new SDIO-based one plus a regulator-always-on fix, and (for sunxi-6.18) imports several upstream A523 SPI/IRQ/clock fixes. The board config drops the 1 GB RAM mention and unused partition variables and sets HAS_VIDEO_OUTPUT=no; the family config drops the explicit bl31 ATF target and the write_uboot_platform() helper.
Changes:
- Updated/added kernel DTS patches for UART1/Bluetooth and Wi‑Fi (incl.
wifi_pwrseq,reg_3v3_wifi, BLDO1 always-on) for bothsunxi-6.18andsunxi-7.0. - Imported A523 SPI controller, R-SPI clock, pinctrl IRQ-remux removal, and pinctrl GPIO-IRQ fix patches into
sunxi-6.18series. - Cleaned up board/family configuration: removed unused partition vars and
write_uboot_platform, simplifiedATF_TARGET_MAP.
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| patch/kernel/archive/sunxi-7.0/series.conf | Adds new wifi + regulator patches to series. |
| patch/kernel/archive/sunxi-7.0/patches.backports/23-fix-wifi-regulator-cubie-a5e.patch | Marks reg_bldo1 always-on. |
| patch/kernel/archive/sunxi-7.0/patches.backports/22-Enable-wifi-on-Radxa-Cubie-A5E.patch | New mmc1/Wi‑Fi DTS nodes with pwrseq. |
| patch/kernel/archive/sunxi-7.0/patches.backports/21-Enable-uart1-on-Radxa-Cubie-A5E.patch | Refreshes UART1 + adds bluetooth child node. |
| patch/kernel/archive/sunxi-6.18/series.conf | Removes old 20-Add-wifi… and adds 22/31/32/33/34. |
| patch/kernel/archive/sunxi-6.18/patches.backports/34-fix-wifi-regulator-cubie-a5e.patch | Same BLDO1 always-on fix. |
| patch/kernel/archive/sunxi-6.18/patches.backports/33-arm64-dts-allwinner-a523-Add_missing_GPIO_interrupt.patch | Adds missing first A523 GPIO IRQ. |
| patch/kernel/archive/sunxi-6.18/patches.backports/32-pinctrl-sunxi-a523-Remove_unneeded_IRQ_remuxing_flag.patch | Removes broken irq_read_needs_mux quirk for A523. |
| patch/kernel/archive/sunxi-6.18/patches.backports/31-clk_sunxi-ng_sun55i-a523-r_Add_missing_r-spi_module_clock.patch | Adds missing r-spi module clock to PRCM CCU. |
| patch/kernel/archive/sunxi-6.18/patches.backports/30-allwinner-a523-support-spi-controllers.patch | Updates SPI DMA channels to mcu_dma 13. |
| patch/kernel/archive/sunxi-6.18/patches.backports/22-Enable-wifi-on-Radxa-Cubie-A5E.patch | New mmc1/Wi‑Fi DTS nodes with pwrseq. |
| patch/kernel/archive/sunxi-6.18/patches.backports/21-Enable-uart1-on-Radxa-Cubie-A5E.patch | Refreshes UART1 + adds bluetooth child node. |
| patch/kernel/archive/sunxi-6.18/patches.backports/20-Add-wifi-to-Radxa-Cubie-A5E.patch | Deletes the previous Wi‑Fi DTS patch. |
| config/sources/families/sun55iw3.conf | Drops bl31 from ATF target and removes write_uboot_platform(). |
| config/boards/radxa-cubie-a5e.csc | RAM spec updated; partition variables removed; HAS_VIDEO_OUTPUT=no. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- fix missing space Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Add hardware descriptors (suggested by @EvilOlaf)
Collaborator
Author
|
Build log : https://paste.armbian.eu/eyexigahaw System Log: https://paste.armbian.com/iwojabuyix WiFi connected: |
igorpecovnik
approved these changes
May 18, 2026
Member
igorpecovnik
left a comment
igorpecovnik
left a comment
There was a problem hiding this comment.
Make automation happy and we are ready to go. I think you can also mv to .conf as its well done.
Contributor
|
✅ This PR has been reviewed and approved — all set for merge! |
Collaborator
Author
If board config has "csc" BOARD_MAINTAINER is optional? |
Member
Yes. |
Collaborator
Author
|
Look: |
juanesf
requested review from
ColorfulRhino,
SuperKali,
amazingfate and
rpardini
as code owners
github-actions
Bot
added
Needs review
Collaborator
Author
|
kernel 7.0 build log: https://paste.armbian.eu/iqihatuzay |
Member
|
ready? |
2 tasks
…l 7.0" This reverts commit 0733a2f.
Collaborator
Author
|
To finalize version 7.0, I can start another request. |
Member
|
Any objection to squash? |
Collaborator
Author
For me, nop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update for Radxa Cubie A5E
Remove unnecessary lines in radxa-cubie-a5e.csc.
Remove 1GB RAM board description (different memory issue).
Remove unnecessary instruction in sun55iw3.conf
How Has This Been Tested?
compiled and tested on:
Summary by CodeRabbit
New Features
Bug Fixes
Chores