Skip to content

Update radxa-cubie-a5e.csc with current kernel for build#9874

Merged
EvilOlaf merged 2 commits into
mainfrom
juanesf-patch-1
May 22, 2026
Merged

Update radxa-cubie-a5e.csc with current kernel for build#9874
EvilOlaf merged 2 commits into
mainfrom
juanesf-patch-1

Conversation

@juanesf
Copy link
Copy Markdown
Collaborator

@juanesf juanesf commented May 21, 2026

Description

( description generated by Copilot and also the "Title")
This pull request updates the kernel target configuration for the radxa-cubie-a5e board to support both the current and edge kernel targets instead of just edge.

  • Configuration update:
    • Modified the KERNEL_TARGET in config/boards/radxa-cubie-a5e.csc to include both current and edge kernels, allowing the board to be built with either kernel version.Add "current" kernel (for build?)

Summary by CodeRabbit

  • Chores
    • Updated kernel build target for the Radxa Cubie A5E to include both "current" and "edge", offering greater flexibility in available kernel versions.
    • Added a kernel test target set to "current,edge" to enable running test builds across those kernel streams for validation and QA.

Review Change Stack

Add "current" kernel (for build?)
@juanesf juanesf requested a review from igorpecovnik as a code owner May 21, 2026 17:38
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 21, 2026

📝 Walkthrough

Walkthrough

KERNEL_TARGET in the Radxa Cubie A5E board config is changed from edge to current,edge, and a new KERNEL_TEST_TARGET set to current,edge is added.

Changes

Kernel Target Configuration Update

Layer / File(s) Summary
Kernel target expansion
config/boards/radxa-cubie-a5e.csc
KERNEL_TARGET changed from edgecurrent,edge and KERNEL_TEST_TARGET added with value current,edge.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

Patches

Suggested reviewers

  • igorpecovnik

Poem

🐰 A kernel grows in dual directions,
Current and edge in gentle sessions,
One file now holds both paths bright,
The Cubie hops from day to night,
Config snug, the builds take flight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: updating the board configuration with current kernel support for building.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch juanesf-patch-1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions Bot added size/small PR with less then 50 lines 05 Milestone: Second quarter release Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... labels May 21, 2026
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@config/boards/radxa-cubie-a5e.csc`:
- Line 10: KERNEL_TARGET is set to "current,edge" but the radxa-aic8800 DKMS
install is conditionally skipped in
post_install_kernel_debs__install_aic8800_dkms_package()
(extensions/radxa-aic8800.sh) when linux-version compare "${KERNEL_MAJOR_MINOR}"
ge 6.20, which can leave AIC8800 WiFi/BT missing for one of the kernel targets;
ensure both kernel targets produce images with working AIC8800 by either (a)
adjusting the condition in
post_install_kernel_debs__install_aic8800_dkms_package() to install DKMS when
AIC8800_TYPE="sdio" regardless of KERNEL_MAJOR_MINOR, or (b) adding shore-up
packaging or in-tree module fallback for the affected kernel target, and then
run at least one full build and basic WiFi+Bluetooth functional check for both
KERNEL_TARGET values to confirm the radxa-aic8800 extension and
AIC8800_TYPE="sdio" result in usable firmware/modules.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: de2092f2-b55a-4086-b20f-c0f29836ca02

📥 Commits

Reviewing files that changed from the base of the PR and between 574b46a and 3f9c17b.

📒 Files selected for processing (1)
  • config/boards/radxa-cubie-a5e.csc

Comment thread config/boards/radxa-cubie-a5e.csc
- Add KERNEL_TEST_TARGET
@juanesf
Copy link
Copy Markdown
Collaborator Author

juanesf commented May 21, 2026

In the latest generation of "Armbian Community" images, only the edge image (7.0.x) is available.

@github-actions
Copy link
Copy Markdown
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions Bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels May 22, 2026
@EvilOlaf EvilOlaf merged commit 7e011c8 into main May 22, 2026
19 checks passed
@EvilOlaf EvilOlaf deleted the juanesf-patch-1 branch May 22, 2026 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

05 Milestone: Second quarter release Hardware Hardware related like kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants