Merge pull request #17 from arnabnandy7/hotfix/testCoverage

Hotfix/test coverage

Author: arnabnandy7

src/lib/compare.ts

@@ -7,16 +7,18 @@ export type ComparedEnvironments = {
   prod: boolean;
 };
 
+const DEFAULT_COMPARED_ENVIRONMENTS: ComparedEnvironments = {
+  dev: true,
+  qa: true,
+  prod: true,
+};
+
 export function compareJson(
   devJson: unknown,
   qaJson: unknown,
   prodJson: unknown,
   ignoreFields: string[] = [],
-  comparedEnvironments: ComparedEnvironments = {
-    dev: true,
-    qa: true,
-    prod: true,
-  },
+  comparedEnvironments: ComparedEnvironments = DEFAULT_COMPARED_ENVIRONMENTS,
 ): DiffEntry[] {
   const environments = [
     {
@@ -42,7 +44,7 @@ export function compareJson(
 
   const paths = Array.from(
     new Set(environments.flatMap((environment) => Object.keys(environment.values))),
-  ).sort();
+  ).sort((left, right) => left.localeCompare(right));
 
   return paths.reduce<DiffEntry[]>((diffs, path) => {
     if (isIgnoredPath(path, ignoreKeys)) {

test/app/api/proxy/route.test.ts

@@ -172,6 +172,85 @@ describe('GET /api/proxy', () => {
     });
   });
 
+  it('returns 400 for invalid structured proxy request JSON', async () => {
+    const request = new Request('http://localhost/api/proxy', {
+      method: 'POST',
+      headers: { 'content-type': 'application/json' },
+      body: '{not-json',
+    });
+
+    const response = await POST(request);
+
+    expect(response.status).toBe(400);
+    expect(await response.json()).toEqual({ error: 'Invalid proxy request body' });
+  });
+
+  it('returns 400 for malformed structured proxy requests', async () => {
+    const request = new Request('http://localhost/api/proxy', {
+      method: 'POST',
+      headers: { 'content-type': 'application/json' },
+      body: JSON.stringify({
+        url: 'https://api.example.com/items',
+        headers: {
+          accept: 42,
+        },
+      }),
+    });
+
+    const response = await POST(request);
+
+    expect(response.status).toBe(400);
+    expect(await response.json()).toEqual({ error: 'Invalid proxy request body' });
+  });
+
+  it('rejects oversized structured request bodies before fetching', async () => {
+    const request = new Request('http://localhost/api/proxy', {
+      method: 'POST',
+      headers: { 'content-type': 'application/json' },
+      body: JSON.stringify({
+        url: 'https://api.example.com/items',
+        method: 'POST',
+        body: 'x'.repeat(1024 * 1024 + 1),
+      }),
+    });
+
+    const response = await POST(request);
+
+    expect(response.status).toBe(400);
+    expect(await response.json()).toEqual({ error: 'Request body is too large' });
+    expect(mockFetch).not.toHaveBeenCalled();
+  });
+
+  it('returns 502 with response body when the remote server fails', async () => {
+    mockFetch.mockResolvedValueOnce(
+      new Response('{"error":"upstream"}', {
+        status: 503,
+        statusText: 'Service Unavailable',
+      }),
+    );
+    const request = new Request('http://localhost/api/proxy?url=https://api.example.com/data');
+
+    const response = await GET(request);
+
+    expect(response.status).toBe(502);
+    expect(await response.json()).toEqual({
+      error: 'Remote request failed: 503 Service Unavailable',
+      body: '{"error":"upstream"}',
+    });
+  });
+
+  it('returns 502 when a redirect is missing its location header', async () => {
+    mockFetch.mockResolvedValueOnce(new Response(null, { status: 302 }));
+    const request = new Request('http://localhost/api/proxy?url=https://api.example.com/data');
+
+    const response = await GET(request);
+
+    expect(response.status).toBe(502);
+    expect(await response.json()).toEqual({
+      error: 'Unable to fetch URL: Remote server returned a redirect without a location',
+    });
+  });
+
   it('returns the underlying network error code for failed requests', async () => {
     mockFetch.mockRejectedValueOnce(
       new Error('fetch failed', {

test/app/layout.test.tsx

@@ -0,0 +1,51 @@
+import '@testing-library/jest-dom/vitest';
+import { cleanup, render, screen } from '@testing-library/react';
+import { afterEach, describe, expect, it, vi } from 'vitest';
+
+const { themeProvider } = vi.hoisted(() => ({
+  themeProvider: vi.fn(
+    ({ children }: { children: React.ReactNode }) => (
+      <div data-testid="theme-provider">{children}</div>
+    ),
+  ),
+}));
+
+vi.mock('@/src/components/theme-provider', () => ({
+  ThemeProvider: themeProvider,
+}));
+
+import RootLayout, { metadata } from '@/src/app/layout';
+
+afterEach(() => {
+  cleanup();
+  vi.clearAllMocks();
+});
+
+describe('RootLayout', () => {
+  it('exports page metadata', () => {
+    expect(metadata).toEqual({
+      title: 'API Response Comparator',
+      description:
+        'Compare JSON API responses across Dev, QA, and Prod using JSON, URLs, or cURL.',
+    });
+  });
+
+  it('renders children inside the theme provider', () => {
+    render(
+      <RootLayout>
+        <main>Comparator app</main>
+      </RootLayout>,
+    );
+
+    expect(screen.getByText('Comparator app')).toBeInTheDocument();
+    expect(screen.getByTestId('theme-provider')).toBeInTheDocument();
+    expect(themeProvider).toHaveBeenCalledWith(
+      expect.objectContaining({
+        attribute: 'class',
+        defaultTheme: 'system',
+        enableSystem: true,
+      }),
+      undefined,
+    );
+  });
+});