Add .travis.yml and test target by dmjio · Pull Request #12 · arrayfire/arrayfire-haskell

dmjio · 2019-11-05T06:34:36Z

No description provided.

chessai · 2019-11-05T15:48:18Z

Why not use haskell-ci (which is really good), using travis for ubuntu? Unless you can have multiple travis setups for nix and non-nix builds. We could potentially test-drive typhon here for nix

dmjio · 2019-11-05T16:24:28Z

@chessai I'll check out haskell-ci tonight, bigger issue is why cabal on ubuntu doesn't respect extra-lib-dirs and extra-include-dirs in the cabal file after cabal configure

noughtmare · 2019-11-06T18:41:25Z

@chessai try passing the -v3 flag to cabal.

chessai · 2019-11-06T18:52:01Z

why is a travis build not triggering on the most recent commits?

noughtmare · 2019-11-06T19:19:43Z

@chessai It is working again, but you added -v3 in the wrong place.

noughtmare · 2019-11-06T20:58:04Z

The log shows:

/usr/bin/gcc returned ExitFailure 1 with error message:
gcc: error: /opt/arrayfire/lib: No such file or directory

I think this is because of the ld-options field in the cabal file. I think it is best if the entire field is removed completely.

chessai · 2019-11-06T21:06:10Z

okay, configure seems to succeed now. however, hspec-discover fails.

noughtmare · 2019-11-06T21:06:42Z

Yes, I fixed that error on my machine by running cabal install hspec-discover.

chessai · 2019-11-06T21:13:12Z

most recent failure seems spurious (just adding hvr-ppa)

chessai · 2019-11-06T21:14:36Z

changed cabal to ${CABAL}. typo

chessai · 2019-11-06T21:19:16Z

use $WITHCOMPILER

chessai · 2019-11-06T21:19:36Z

sorry, i keep forgetting that git with do weird things with '$'-prefixed strings.

noughtmare · 2019-11-06T21:24:45Z

Now we're seeing real errors 🎉

chessai · 2019-11-06T21:24:53Z

okay, the library is building, but running anything is failing with:

/tmp/dist-test.N8AS/dist-newstyle/build/x86_64-linux/ghc-8.8.1/arrayfire-0.1.0.0/build/libHSarrayfire-0.1.0.0-inplace.a(LAPACK.o)(.text+0x71f): error: undefined reference to 'af_pinverse'
/tmp/dist-test.N8AS/dist-newstyle/build/x86_64-linux/ghc-8.8.1/arrayfire-0.1.0.0/build/libHSarrayfire-0.1.0.0-inplace.a(Image.o)(.text+0x48a5): error: undefined reference to 'af_iterative_deconv'
/tmp/dist-test.N8AS/dist-newstyle/build/x86_64-linux/ghc-8.8.1/arrayfire-0.1.0.0/build/libHSarrayfire-0.1.0.0-inplace.a(Image.o)(.text+0x4be4): error: undefined reference to 'af_inverse_deconv'
/tmp/dist-test.N8AS/dist-newstyle/build/x86_64-linux/ghc-8.8.1/arrayfire-0.1.0.0/build/libHSarrayfire-0.1.0.0-inplace.a(LAPACK.o)(.text+0x1000): error: undefined reference to 'af_pinverse'
/tmp/dist-test.N8AS/dist-newstyle/build/x86_64-linux/ghc-8.8.1/arrayfire-0.1.0.0/build/libHSarrayfire-0.1.0.0-inplace.a(Signal.o)(.text+0x4aa): error: undefined reference to 'af_approx1_uniform'
/tmp/dist-test.N8AS/dist-newstyle/build/x86_64-linux/ghc-8.8.1/arrayfire-0.1.0.0/build/libHSarrayfire-0.1.0.0-inplace.a(Signal.o)(.text+0xa6f): error: undefined reference to 'af_approx2_uniform'

noughtmare · 2019-11-06T21:25:41Z

That was fixed in #17

chessai · 2019-11-06T21:25:58Z

ok, rebasing

chessai · 2019-11-06T21:32:20Z

once a build with 8.8.1 passes, i will re-add the older ghcs

noughtmare · 2019-11-06T21:33:29Z

It seems that #23 forgot to also remove the tests for the Ord instance.

chessai · 2019-11-06T21:33:30Z

/tmp/dist-test.Iv7D/dist-newstyle/build/x86_64-linux/ghc-8.8.1/arrayfire-0.3.0.0/t/test/build/test/test: error while loading shared libraries: libaf.so.3: cannot open shared object file: No such file or directory
Test suite test: FAIL 
Test suite logged to: /tmp/dist-test.Iv7D/dist-newstyle/build/x86_64-linux/ghc-8.8.1/arrayfire-0.3.0.0/t/test/test/arrayfire-0.3.0.0-test.log 
0 of 1 test suites (0 of 1 test cases) passed. 
-----BEGIN CABAL OUTPUT-----
cabal: Tests failed for test:test from arrayfire-0.3.0.0.
-----END CABAL OUTPUT-----

looks like this isnt getting copied in properly

noughtmare · 2019-11-06T21:34:56Z

It is strange. There are two builds, pr and push, and they give different outputs:

chessai · 2019-11-06T21:36:06Z

hmm. that is strange.

chessai · 2019-11-06T21:38:06Z

do i need to remove the Ord tests from the test suite?

noughtmare · 2019-11-06T21:38:16Z

Yes, I think so.

chessai · 2019-11-06T21:43:51Z

now we at least see the same error on both.

noughtmare · 2019-11-06T21:46:02Z

Oh, I think I know how to fix this. The linux documentation of arrayfire mentions that you have to do this:

Given sudo permissions, you can add the ArrayFire libraries via ldconfig like so:
echo /opt/arrayfire/lib64 > /etc/ld.so.conf.d/arrayfire.conf
sudo ldconfig
Otherwise, you will need to set the LD_LIBRARY_PATH environment variable in order to let your shared library loader find the ArrayFire libraries.

noughtmare · 2019-11-06T21:47:14Z

I think that is also the reason for the ld-options field in the cabal file.

So another alternative we have is putting:

ld-options: -Wl,-rpath /opt/arrayfire/lib64

back in the cabal file.

(not -Wl,-rpath /opt/arrayfire/lib)

chessai · 2019-11-06T21:49:43Z

we could do that. would it be better instead to do export LD_LIBRARY_PATH="/opt/arrayfire/lib64:$LD_LIBRARY_PATH"?

noughtmare · 2019-11-06T21:50:56Z

Yes, that would also work.

noughtmare · 2019-11-06T21:53:14Z

I don't know if it carries over from before-install to script, but we will see.

chessai · 2019-11-06T21:53:38Z

me either. i should probably just do it right after the arrayfire script finishes.

chessai · 2019-11-06T21:54:58Z

failure on push is spurious.

chessai · 2019-11-06T21:56:33Z

actually, those have to be persisting, because a lot of them are actually used during install. so i'm less worried about that. for example, if the extension to PATH to include $CABALHOME/bin didn't persist, the hspec-discover failure would still be occurring.

chessai · 2019-11-06T21:58:55Z

extending LD_LIBRARY_PATH worked.

Test suite now fails with:

Failures:
  test/ArrayFire/ArithSpec.hs:31:7: 
  1) ArrayFire.Arith, Arith tests, Should take cubed root
       expected: ArrayFire Array
                 [1 1 1 1]
                     3.0000 
                 
        but got: ArrayFire Array
                 [1 1 1 1]
                     3.0000 
                 
  To rerun use: --match "/ArrayFire.Arith/Arith tests/Should take cubed root/"
Randomized with seed 938744424

Which i think is a problem with floating point arithemtic

noughtmare · 2019-11-06T21:59:10Z

test/ArrayFire/ArithSpec.hs:31:7: 
1) ArrayFire.Arith, Arith tests, Should take cubed root
     expected: ArrayFire Array
               [1 1 1 1]
                   3.0000 

      but got: ArrayFire Array
               [1 1 1 1]
                   3.0000

🤔

chessai · 2019-11-06T22:07:06Z

perhaps we should add a shouldBeEps :: Array Double -> ArrayFire Double -> Expectation that compares for equality within some epsilon.

chessai · 2019-11-06T22:41:41Z

push failure is spurious

chessai · 2019-11-06T23:19:13Z

nice. it built and passed.

chessai · 2019-11-06T23:24:22Z

added ghc 8.6.5 and 8.4.4.

chessai · 2019-11-07T01:09:15Z

Configure fails on older ghcs/cabal 2.4. Havent looked into it.

chessai · 2019-11-08T15:35:20Z

i am going to get arrayfire locally so i can test without travis. i don't know why configure is failing on older ghcs, but not 881 with cabal 3.0

noughtmare · 2019-11-09T10:44:49Z

lapack spec: failing with "free(): invalid next size (normal)"

I get a similar error message in #13 (comment).

- use haskell-ci - download arrayfire installer and unpack to /opt/arrayfire/ - remove Ord tests from test suite - use shouldBeEps for comparing Array Double nix updates - change shellHooks to use runhaskell instead of cabal-v1 - extend LD_LIBRARY_PATH to include $AF_LIB - ghcid shellHook uses -fno-nocode - get tests to build and _almost_ pass

chessai · 2019-11-20T12:13:34Z

just trying to appease travis right now, because locally everything is fine.

chessai · 2019-11-20T12:21:10Z

OK, we now have CI for GHC 8.4.4, 8.6.5, and 8.8.1. @noughtmare @dmjio please review when you have time.

chessai · 2019-11-20T12:29:09Z

have to add back LAPACK/doctest tests

dmjio · 2026-06-07T18:23:24Z

We have a working nix build w/ GitHub CI for linux / osx now, #67 #69

dmjio force-pushed the travis branch from 1751e09 to f7aecad Compare November 5, 2019 06:35

noughtmare reviewed Nov 5, 2019

View reviewed changes

Comment thread arrayfire.cabal Outdated

chessai closed this Nov 6, 2019

chessai reopened this Nov 6, 2019

chessai force-pushed the travis branch from 6ed9771 to 4f1d712 Compare November 6, 2019 21:27

noughtmare reviewed Nov 6, 2019

View reviewed changes

Comment thread test/ArrayFire/ArithSpec.hs Outdated

chessai mentioned this pull request Nov 6, 2019

update nixpkgs to use arrayfire 3.6.4 stable #28

Closed

chessai force-pushed the travis branch from 0fe3725 to 43aefa4 Compare November 6, 2019 23:24

chessai force-pushed the travis branch from 76ae58a to 38dcf76 Compare November 20, 2019 11:51

chessai added 3 commits November 20, 2019 07:03

fix merge conflicts

6b1e6ce

fix missing end semicolon in pkg.nix

f967749

use v2-install and not v1-install on cabal v2

7b27ca3

dmjio closed this Jun 7, 2026

Conversation

dmjio commented Nov 5, 2019

Uh oh!

Uh oh!

chessai commented Nov 5, 2019

Uh oh!

dmjio commented Nov 5, 2019

Uh oh!

noughtmare commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

noughtmare commented Nov 6, 2019

Uh oh!

noughtmare commented Nov 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

noughtmare commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

noughtmare commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

noughtmare commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

noughtmare commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

noughtmare commented Nov 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

noughtmare commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

noughtmare commented Nov 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

noughtmare commented Nov 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

noughtmare commented Nov 6, 2019

Uh oh!

noughtmare commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

noughtmare commented Nov 6, 2019

Uh oh!

chessai commented Nov 6, 2019

Uh oh!

Uh oh!

chessai commented Nov 6, 2019

noughtmare commented Nov 6, 2019 •

edited

Loading

noughtmare commented Nov 6, 2019 •

edited

Loading

noughtmare commented Nov 6, 2019 •

edited

Loading

noughtmare commented Nov 6, 2019 •

edited

Loading

chessai commented Nov 6, 2019 •

edited

Loading

dmjio commented Jun 7, 2026 •

edited

Loading