Skip to content

Add support for application mime-type & remove redundant files #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abarisic86 wants to merge 10 commits into from
Closed

Add support for application mime-type & remove redundant files #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1b79e90
prepare for application data
abarisic86 May 3, 2018
4d773bc
enable open url
abarisic86 May 10, 2018
2bc4c30
stringByAddingPercentEscapesUsingEncoding was deprecated. Changing it…
May 18, 2018
7ca379f
Reverting the changes. This wasn't causing the app to fail. Actually,…
May 21, 2018
f439c1d
Enable opening external files with the application
damir-sirola Jun 27, 2018
0142811
Merge pull request #1 from damir-sirola/patch-1
Taarna Jun 27, 2018
469a0e7
Exit extension on close so that it can be called again
damir-sirola Jun 28, 2018
25a2ad5
Merge pull request #2 from damir-sirola/patch-2
Taarna Jun 28, 2018
8dfa3f2
Remove exit from iOS code
damir-sirola Jul 5, 2018
a1705ec
Merge pull request #3 from damir-sirola/patch-3
Taarna Jul 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions android/src/main/java/com/alinz/parkerdan/shareextension/ShareModule.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ public WritableArray processIntent() {
mediaTypesSupported.add("video");
mediaTypesSupported.add("audio");
mediaTypesSupported.add("image");
mediaTypesSupported.add("application");

String type = "";
String action = "";
Expand All @@ -67,8 +68,7 @@ public WritableArray processIntent() {
dataMap.putString("type", type);
dataMap.putString("value", intent.getStringExtra(Intent.EXTRA_TEXT));
dataArrayMap.pushMap(dataMap);
} else if (Intent.ACTION_SEND.equals(action) && (
mediaTypesSupported.contains(typePart))) {
} else if (Intent.ACTION_SEND.equals(action) && mediaTypesSupported.contains(typePart)) {
WritableMap dataMap = Arguments.createMap();
dataMap.putString("type", type);
Uri uri = (Uri) intent.getParcelableExtra(Intent.EXTRA_STREAM);
Expand All @@ -82,6 +82,12 @@ public WritableArray processIntent() {
dataMap.putString("value", "file://" + RealPathUtil.getRealPathFromURI(currentActivity, uri));
dataArrayMap.pushMap(dataMap);
}
} else if (Intent.ACTION_VIEW.equals(action) && mediaTypesSupported.contains(typePart)) {
WritableMap dataMap = Arguments.createMap();
dataMap.putString("type", type);
Uri uri = intent.getData();
dataMap.putString("value", "file://" + RealPathUtil.getRealPathFromURI(currentActivity, uri));
dataArrayMap.pushMap(dataMap);
}
}
return dataArrayMap;
Expand Down
71 changes: 0 additions & 71 deletions android/src/main/java/com/github/alinz/reactNativeShareExtension/ShareExModule.java
View file
Open in desktop

This file was deleted.

24 changes: 0 additions & 24 deletions android/src/main/java/com/github/alinz/reactNativeShareExtension/ShareExPackage.java
View file
Open in desktop

This file was deleted.

6 changes: 5 additions & 1 deletion ios/ReactNativeShareExtension.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,11 @@ - (void)viewDidLoad {
completionHandler:nil];
}


RCT_EXPORT_METHOD(openURL:(NSString *)url) {
UIApplication *application = [UIApplication sharedApplication];
NSURL *urlToOpen = [NSURL URLWithString:[url stringByAddingPercentEscapesUsingEncoding:NSUTF8StringEncoding]];
[application openURL:urlToOpen options:@{} completionHandler: nil];
}

RCT_REMAP_METHOD(data,
resolver:(RCTPromiseResolveBlock)resolve
Expand Down
3 changes: 2 additions & 1 deletion lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,6 @@ import { NativeModules } from 'react-native'
// NativeModules.ShareExtension.close()
export default {
data: () => NativeModules.ReactNativeShareExtension.data(),
close: () => NativeModules.ReactNativeShareExtension.close()
close: () => NativeModules.ReactNativeShareExtension.close(),
openURL: url => NativeModules.ReactNativeShareExtension.openURL(url),
}