fix(factory): treat explicit tzinfo=None the same as omitting tzinfo#1277
Open
theohmwoa wants to merge 1 commit into
Open
fix(factory): treat explicit tzinfo=None the same as omitting tzinfo#1277theohmwoa wants to merge 1 commit into
theohmwoa wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1277 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 2315 2315
Branches 358 358
=========================================
Hits 2315 2315 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
arrow.get(value, format, tzinfo=None)raisedTypeError: Arrow.__init__() missing 1 required positional argument: 'day'because the factory's routing check used the value oftz(which defaults toNone) to detect whether thetzinfokwarg was supplied. When a caller explicitly passedtzinfo=None, the check incorrectly forcedarg_count = 3and routed the call to the multi-argArrow(year, month, day, ...)constructor path.The fix replaces
tz is Nonewith"tzinfo" not in kwargs, which actually answers the question the existing comment already promised (# tzinfo kwarg is not provided).Reproduction
Test
Added
TestGet.test_two_args_str_str_tzinfo_noneintests/test_factory.py. It asserts thatfactory.get("2025-01-01", "YYYY-MM-DD", tzinfo=None)no longer raises, equalsfactory.get("2025-01-01", "YYYY-MM-DD"), and yields the expected UTC datetime. Full suite passes (1903 tests, 99.93% coverage).Fixes #1259.